server: throw exception when update vm nic on L2 network #4625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this change
```
root@mgt01:~# cmk update vmnicip nicid=afab73cb-f4f4-490f-a524-365edef432b7
{
"accountid": "a27bffc1-48ee-11eb-8680-069fc4003392",
"cmd": "org.apache.cloudstack.api.command.user.vm.UpdateVmNicIpCmd",
"completed": "2020-12-28T12:55:27+0000",
"created": "2020-12-28T12:55:27+0000",
"jobid": "88af30e0-214b-4379-9c39-49648f998ff6",
"jobprocstatus": 0,
"jobresult": {
"errorcode": 530,
"errortext": "Failed to update ip address on vm NIC. Refer to server logs for details."
},
"jobresultcode": 530,
"jobresulttype": "object",
"jobstatus": 2,
"userid": "a27f45f5-48ee-11eb-8680-069fc4003392"
}
🙈 Error: async API failed for job 88af30e0-214b-4379-9c39-49648f998ff6
```
with this change
```
root@mgt01:~# cmk update vmnicip nicid=22d79189-6754-4dfe-a8c4-0ba21be2ada5
{
"accountid": "044bb5a9-32fd-11eb-b251-06b6e80033a6",
"cmd": "org.apache.cloudstack.api.command.user.vm.UpdateVmNicIpCmd",
"completed": "2020-12-28T12:55:15+0000",
"created": "2020-12-28T12:55:15+0000",
"jobid": "f4ccb545-0e47-4e9c-b562-b0e6cf52ddd7",
"jobprocstatus": 0,
"jobresult": {
"errorcode": 431,
"errortext": "UpdateVmNicIpCmd is not supported in L2 network"
},
"jobresultcode": 530,
"jobresulttype": "object",
"jobstatus": 2,
"userid": "044cc6e3-32fd-11eb-b251-06b6e80033a6"
}
🙈 Error: async API failed for job f4ccb545-0e47-4e9c-b562-b0e6cf52ddd7
```
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2604 |
Member
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-3442)
|
DaanHoogland
approved these changes
Jan 29, 2021
| } else { | ||
| s_logger.error("UpdateVmNicIpCmd is not supported in this network..."); | ||
| return null; | ||
| throw new InvalidParameterValueException("UpdateVmNicIpCmd is not supported in L2 network"); |
Contributor
There was a problem hiding this comment.
I'd say it is cleaner to move this to line 1545 as
Suggested change
| throw new InvalidParameterValueException("UpdateVmNicIpCmd is not supported in L2 network"); | |
| if(! Network.GuestType.Isolated.equals(network.getGuestType()) { | |
| throw new InvalidParameterValueException("UpdateVmNicIpCmd is only supported in GUEST networks"); | |
| } |
#nitpicking
DaanHoogland
pushed a commit
that referenced
this pull request
Feb 1, 2021
* 4.14: server: select root disk based on user input during vm import (#4591) kvm: Use Q35 chipset for UEFI x86_64 (#4576) server: fix wrong error message when create isolated network without SourceNat (#4624) server: add possibility to scale vm to current customer offerings (#4622) server: keep networks order and ips while move a vm with multiple networks (#4602) server: throw exception when update vm nic on L2 network (#4625) doc: fix typo in install notes (#4633)
DaanHoogland
pushed a commit
that referenced
this pull request
Feb 1, 2021
* 4.15: server: select root disk based on user input during vm import (#4591) kvm: Use Q35 chipset for UEFI x86_64 (#4576) server: fix wrong error message when create isolated network without SourceNat (#4624) server: add possibility to scale vm to current customer offerings (#4622) server: keep networks order and ips while move a vm with multiple networks (#4602) server: throw exception when update vm nic on L2 network (#4625) doc: fix typo in install notes (#4633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR throws an exception when update vm nic ip on L2 network. The error text is not clear now.
without this change
with this change
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?