Skip to content

server: fix wrong error message when create isolated network without SourceNat #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohityadavcloud merged 1 commit into from
Feb 1, 2021
Merged

server: fix wrong error message when create isolated network without SourceNat #4624

rohityadavcloud merged 1 commit into from
Feb 1, 2021

Conversation

@ustcweizhou
Copy link
Contributor

@ustcweizhou ustcweizhou commented Jan 27, 2021

Description

This PR fixes wrong message when create isolated network without SourceNat

When I created network without sourcenat, I got message below

(localcloud) 🐱 > create network name=fully-isolated-noservices displaytext=fully-isolated-noservices networkofferingid=83f13c21-38fd-439f-a0fc-54d6d5233fec zoneid=70e90072-db05-42c0-a639-71d16d905406
🙈 Error: (HTTP 431, error code 4350) StartIp/endIp/gateway/netmask are required when create network of type Shared and network of type Isolated with service SourceNat disabled

However, when I passed StartIp/endIp/gateway/netmask, it also failed.

(localcloud) 🐱 > create network name=fully-isolated-noservices displaytext=fully-isolated-noservices networkofferingid=83f13c21-38fd-439f-a0fc-54d6d5233fec zoneid=70e90072-db05-42c0-a639-71d16d905406 startip=192.168.101.2 endip=192.168.101.20 gateway=192.168.101.1 netmask=255.255.255.0
🙈 Error: (HTTP 431, error code 4350) Network offering with specified id doesn't support adding multiple ip ranges

without startip/endip, the following worked.

create network name=fully-isolated-noservices displaytext=fully-isolated-noservices networkofferingid=83f13c21-38fd-439f-a0fc-54d6d5233fec zoneid=70e90072-db05-42c0-a639-71d16d905406 gateway=192.168.102.1 netmask=255.255.255.0

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@rohityadavcloud rohityadavcloud added this to the 4.14.1.0 milestone Jan 27, 2021
@rohityadavcloud
Copy link
Member

rohityadavcloud commented Jan 27, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2021

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2021

Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2605

shwstppr
shwstppr approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Jan 28, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 28, 2021

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 28, 2021

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2610

@shwstppr
Copy link
Contributor

shwstppr commented Jan 29, 2021

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jan 29, 2021

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jan 29, 2021

Trillian test result (tid-3452)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41917 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4624-t3452-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_deploy_kubernetes_cluster Failure 3612.06 test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster Failure 3622.89 test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 77.31 test_kubernetes_clusters.py

@rohityadavcloud rohityadavcloud merged commit 313ae1f into apache:4.14 Feb 1, 2021
DaanHoogland pushed a commit that referenced this pull request Feb 1, 2021
Merge release branch 4.14 to 4.15
b6b778f 
* 4.14:
  server: select root disk based on user input during vm import (#4591)
  kvm: Use Q35 chipset for UEFI x86_64 (#4576)
  server: fix wrong error message when create isolated network without SourceNat (#4624)
  server: add possibility to scale vm to current customer offerings (#4622)
  server: keep networks order and ips while move a vm with multiple networks (#4602)
  server: throw exception when update vm nic on L2 network (#4625)
  doc: fix typo in install notes (#4633)
DaanHoogland pushed a commit that referenced this pull request Feb 1, 2021
Merge release branch 4.15 to master
ff376d8 
* 4.15:
  server: select root disk based on user input during vm import (#4591)
  kvm: Use Q35 chipset for UEFI x86_64 (#4576)
  server: fix wrong error message when create isolated network without SourceNat (#4624)
  server: add possibility to scale vm to current customer offerings (#4622)
  server: keep networks order and ips while move a vm with multiple networks (#4602)
  server: throw exception when update vm nic on L2 network (#4625)
  doc: fix typo in install notes (#4633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@shwstppr shwstppr shwstppr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.14.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ustcweizhou @rohityadavcloud @blueorangutan @shwstppr