Skip to content

Conversation

@ustcweizhou
Copy link
Contributor

Description

We can use cloudmonkey to scale a vm with dynamic offering, to same offering but with different cpunumber or memory.
Enable it on UI to improve user experience.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

We can use cloudmonkey to scale a vm with dynamic offering, to same offering but with different cpunumber or memory.
Enable it on UI to improve user experience.
@ustcweizhou ustcweizhou changed the base branch from master to 4.14 January 27, 2021 13:07
@yadvr yadvr added this to the 4.14.1.0 milestone Jan 27, 2021
@yadvr
Copy link
Member

yadvr commented Jan 27, 2021

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2606

@yadvr
Copy link
Member

yadvr commented Jan 28, 2021

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3443)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4622-t3443-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@shwstppr
Copy link
Contributor

shwstppr commented Feb 1, 2021

Tested, works well as it lists same custom offering for a stopped VM.
Before changes VM's offerring (ID=55008aa9-fc1a-4c8d-a964-150439b5f7b1) is missing in list call,

(localcloud) 🐱 > list virtualmachines id=e8fb9052-6267-47ba-992b-b6e9a3be1cfe filter=id,name,serviceofferingid,serviceofferingname
{
  "count": 1,
  "virtualmachine": [
    {
      "id": "e8fb9052-6267-47ba-992b-b6e9a3be1cfe",
      "name": "t2",
      "serviceofferingid": "55008aa9-fc1a-4c8d-a964-150439b5f7b1",
      "serviceofferingname": "custom2"
    }
  ]
}
(localcloud) 🐱 > list serviceofferings id=55008aa9-fc1a-4c8d-a964-150439b5f7b1 
{
  "count": 1,
  "serviceoffering": [
    {
      "cacheMode": "none",
      "created": "2021-02-01T12:43:44+0530",
      "defaultuse": false,
      "displaytext": "custom2",
      "id": "55008aa9-fc1a-4c8d-a964-150439b5f7b1",
      "iscustomized": true,
      "issystem": false,
      "isvolatile": false,
      "limitcpuuse": false,
      "name": "custom2",
      "offerha": false,
      "provisioningtype": "thin",
      "storagetype": "shared"
    }
  ]
}
(localcloud) 🐱 > list serviceofferings virtualmachineid=e8fb9052-6267-47ba-992b-b6e9a3be1cfe filter=id,name
{
  "count": 3,
  "serviceoffering": [
    {
      "id": "e24e1d1d-b100-4a11-af49-938f6b9a1c8b",
      "name": "Small Instance"
    },
    {
      "id": "5ed52f2b-4732-4073-b9cc-3a9fa04703c7",
      "name": "Medium Instance"
    },
    {
      "id": "d4cf0042-6bd4-42a8-9768-2706f97bd61c",
      "name": "custom1"
    }
  ]
}

After changes,

(localcloud) 🐱 > list virtualmachines id=e8fb9052-6267-47ba-992b-b6e9a3be1cfe filter=id,name,serviceofferingid,serviceofferingname
{
  "count": 1,
  "virtualmachine": [
    {
      "id": "e8fb9052-6267-47ba-992b-b6e9a3be1cfe",
      "name": "t2",
      "serviceofferingid": "55008aa9-fc1a-4c8d-a964-150439b5f7b1",
      "serviceofferingname": "custom2"
    }
  ]
}
(localcloud) 🐱 > list serviceofferings id=55008aa9-fc1a-4c8d-a964-150439b5f7b1 
{
  "count": 1,
  "serviceoffering": [
    {
      "cacheMode": "none",
      "created": "2021-02-01T12:43:44+0530",
      "defaultuse": false,
      "displaytext": "custom2",
      "id": "55008aa9-fc1a-4c8d-a964-150439b5f7b1",
      "iscustomized": true,
      "issystem": false,
      "isvolatile": false,
      "limitcpuuse": false,
      "name": "custom2",
      "offerha": false,
      "provisioningtype": "thin",
      "storagetype": "shared"
    }
  ]
}
(localcloud) 🐱 > list serviceofferings virtualmachineid=e8fb9052-6267-47ba-992b-b6e9a3be1cfe filter=id,name
{
  "count": 4,
  "serviceoffering": [
    {
      "id": "e24e1d1d-b100-4a11-af49-938f6b9a1c8b",
      "name": "Small Instance"
    },
    {
      "id": "5ed52f2b-4732-4073-b9cc-3a9fa04703c7",
      "name": "Medium Instance"
    },
    {
      "id": "d4cf0042-6bd4-42a8-9768-2706f97bd61c",
      "name": "custom1"
    },
    {
      "id": "55008aa9-fc1a-4c8d-a964-150439b5f7b1",
      "name": "custom2"
    }
  ]
}

@yadvr yadvr merged commit a44fb11 into apache:4.14 Feb 1, 2021
DaanHoogland pushed a commit that referenced this pull request Feb 1, 2021
* 4.14:
  server: select root disk based on user input during vm import (#4591)
  kvm: Use Q35 chipset for UEFI x86_64 (#4576)
  server: fix wrong error message when create isolated network without SourceNat (#4624)
  server: add possibility to scale vm to current customer offerings (#4622)
  server: keep networks order and ips while move a vm with multiple networks (#4602)
  server: throw exception when update vm nic on L2 network (#4625)
  doc: fix typo in install notes (#4633)
DaanHoogland pushed a commit that referenced this pull request Feb 1, 2021
* 4.15:
  server: select root disk based on user input during vm import (#4591)
  kvm: Use Q35 chipset for UEFI x86_64 (#4576)
  server: fix wrong error message when create isolated network without SourceNat (#4624)
  server: add possibility to scale vm to current customer offerings (#4622)
  server: keep networks order and ips while move a vm with multiple networks (#4602)
  server: throw exception when update vm nic on L2 network (#4625)
  doc: fix typo in install notes (#4633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants