Skip to content

server: throw exception when update vm nic on L2 network #4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohityadavcloud merged 1 commit into from
Feb 1, 2021
Merged

server: throw exception when update vm nic on L2 network #4625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1648,8 +1648,7 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
return null;
}
} else {
s_logger.error("UpdateVmNicIpCmd is not supported in this network...");
return null;
throw new InvalidParameterValueException("UpdateVmNicIpCmd is not supported in L2 network");
Copy link
Contributor

@DaanHoogland DaanHoogland Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it is cleaner to move this to line 1545 as

Suggested change
throw new InvalidParameterValueException("UpdateVmNicIpCmd is not supported in L2 network");
if(! Network.GuestType.Isolated.equals(network.getGuestType()) {
throw new InvalidParameterValueException("UpdateVmNicIpCmd is only supported in GUEST networks");
}

#nitpicking

}

s_logger.debug("Updating IPv4 address of NIC " + nicVO + " to " + ipaddr + "/" + nicVO.getIPv4Netmask() + " with gateway " + nicVO.getIPv4Gateway());
Expand Down