Skip to content

refactor(tests): convert the medium-risk slice-to-map table tests#322

Merged
mwbrooks merged 11 commits intomainfrom
mwbrooks-table-test-consistent-p5-medium-risk
Feb 4, 2026
Merged

refactor(tests): convert the medium-risk slice-to-map table tests#322
mwbrooks merged 11 commits intomainfrom
mwbrooks-table-test-consistent-p5-medium-risk

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Jan 31, 2026

Summary

Related to #315, #316, #320, #321

This pull request refactors the remaining medium-risk Table Tests from the Slice-to-Map Pattern. It's focused on tests with simple mocking.

Reviewers

My goal is to keep you in the reading chair with some chill tunes and easy reading. 🛋️ 📚 🎵

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Jan 31, 2026
@mwbrooks mwbrooks self-assigned this Jan 31, 2026
@mwbrooks mwbrooks added docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment labels Jan 31, 2026
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.65%. Comparing base (46305ef) to head (159b87c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   64.65%   64.65%           
=======================================
  Files         212      212           
  Lines       17771    17771           
=======================================
  Hits        11489    11489           
  Misses       5205     5205           
  Partials     1077     1077           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks changed the base branch from main to mwbrooks-table-test-consistent-p4-low-risk January 31, 2026 06:48
Base automatically changed from mwbrooks-table-test-consistent-p4-low-risk to main February 2, 2026 21:55
@mwbrooks mwbrooks marked this pull request as ready for review February 2, 2026 21:56
@mwbrooks mwbrooks requested a review from a team as a code owner February 2, 2026 21:56
@mwbrooks
Copy link
Member Author

mwbrooks commented Feb 2, 2026

⚠️ I imagine our checks aren't running because of this incident:
https://www.githubstatus.com/incidents/xwn6hjps36ty

Edit: Looks like we're humming again!

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks Another amazing set of changes - I have good tunes going 🎵 ✨

@mwbrooks
Copy link
Member Author

mwbrooks commented Feb 4, 2026

Woo! Thank you for the review @zimeg! 🙇🏻

@mwbrooks mwbrooks merged commit a76e0a5 into main Feb 4, 2026
8 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-table-test-consistent-p5-medium-risk branch February 4, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants