refactor(tests): convert the low-risk slice-to-map table tests#321
refactor(tests): convert the low-risk slice-to-map table tests#321
Conversation
mwbrooks
added
code health
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 64.61% 64.62% +0.01%
==========================================
Files 212 212
Lines 17755 17755
==========================================
+ Hits 11472 11475 +3
+ Misses 5207 5206 -1
+ Partials 1076 1074 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
changed the base branch from
main
to
mwbrooks-table-test-consistent-p3-slice-to-map-simple
| expectedString: "(#general)", | ||
| }, | ||
| // TODO(@mbrooks) This test represents the current behaviour, but should the expectedString be "C01234" instead? | ||
| // This test represents the current behaviour, but should the expectedString be "C01234" instead? |
There was a problem hiding this comment.
⭐ praise: Thanks for keeping note of this! Calling out strange but expected behavior IMHO is so useful in later refactors with assumptions removed of the unknown!
There was a problem hiding this comment.
Agreed! Documenting unexpected-expected behaviour can save us maintainers a huge amount of mental load. Since we don't have an immediate plan to change this, I thought I'd remove the TODO pointing back at myself 😆
|
@zimeg Thanks again for the review! 🙇🏻 Really appreciate the quick eyes and kind words! |
2 participants
Summary
Related to #315, #316, #320
This pull request refactors the remaining low-risk Table Tests from the Slice-to-Map Pattern. It's focused on simple struct conversions with no setup or teardown functions.
Reviewers
Hoping this is a easy, casual read for you. 📚 🎵
Requirements