Skip to content

Add Redpanda Connect support for Azure BYOVPC #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbatuigas merged 5 commits into from
Jun 4, 2025
Merged

Add Redpanda Connect support for Azure BYOVPC #308

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
848761c
Add missing kafka-connect user assigned identity
tomasz-sadura May 26, 2025
eed71eb
Typo fix
tomasz-sadura May 26, 2025
f61caee
Add Redpanda Connect user assigned identities
tomasz-sadura May 26, 2025
37c984c
Skip resource group creation
tomasz-sadura May 26, 2025
cd1176d
update vars naming to match terraform output
tomasz-sadura Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ cat > byovnet.auto.tfvars.json <<EOF
"zones": ${AZURE_ZONES},
"resource_name_prefix": "${AZURE_RESOURCE_PREFIX}",
"tags": {},
"create_resource_groups": "false",
"redpanda_resource_group_name": "${AZURE_RESOURCE_GROUP_NAME}",
"redpanda_storage_resource_group_name": "${AZURE_RESOURCE_GROUP_NAME}",
"redpanda_network_resource_group_name": "${AZURE_RESOURCE_GROUP_NAME}",
Expand All @@ -108,7 +109,9 @@ cat > byovnet.auto.tfvars.json <<EOF
"aks_identity_name": "aks-uai",
"redpanda_console_identity_name": "console-uai",
"redpanda_console_role_name": "console-role",
"kafka_connect_identity_name": "",
"kafka_connect_identity_name": "kafka-connect-uai",
"redpanda_connect_identity_name": "redpanda-connect-uai",
"redpanda_connect_api_identity_name": "redpanda-connect-api-uai",
"redpanda_management_storage_account_name": "rpmgmtsa",
"redpanda_management_storage_container_name": "rpmgmtsc",
"redpanda_tiered_storage_account_name": "tieredsa",
Expand Down Expand Up @@ -220,6 +223,8 @@ iam_resource_group_name = "my-iam-rg"
kafka_connect_pods_subnet_name = "my-snet-kafka-connect-pods"
kafka_connect_user_assigned_identity_name = "my-kafka-connect-uai"
kafka_connect_vnet_subnet_name = "my-snet-kafka-connect-vnet"
redpanda_connect_user_assigned_identity_name = "my-redpanda-connect-uai"
redpanda_connect_api_user_assigned_identity_name = "my-redpanda-connect-api-uai"
Comment on lines +226 to +227
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Mismatch between Terraform outputs and JSON placeholders
The example output shows:

redpanda_connect_user_assigned_identity_name = "my-redpanda-connect-uai"
redpanda_connect_api_user_assigned_identity_name = "my-redpanda-connect-api-uai"

but the JSON snippets expect $redpanda_connect_assigned_identity_name and $redpanda_connect_api_assigned_identity_name. The extra user_assigned segment in the output variables doesn’t align with the placeholders. This discrepancy will cause variable interpolation failures when creating the cluster. Please reconcile these names across your Terraform outputs, variable definitions, and JSON templates.

🤖 Prompt for AI Agents 
In modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc around
lines 226 to 227, the Terraform output variable names include "user_assigned"
(redpanda_connect_user_assigned_identity_name and
redpanda_connect_api_user_assigned_identity_name), but the JSON placeholders use
redpanda_connect_assigned_identity_name and
redpanda_connect_api_assigned_identity_name without "user_assigned". To fix
this, rename the Terraform output variables to match the JSON placeholders by
removing "user_" from their names, ensuring consistent naming across Terraform
outputs, variable definitions, and JSON templates to avoid interpolation errors.

Copy link
Copy Markdown
Contributor

@kbatuigas kbatuigas Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomasz-sadura would you mind double checking this and confirming whether or not the lines 393-394 below need to also be changed?

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

Copy link
Copy Markdown
Contributor Author

@tomasz-sadura tomasz-sadura Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean to keep the vars naming matching the terraform output? We can do this, I will commit.

management_bucket_storage_account_name = "mymanagement"
management_bucket_storage_container_name = "mymanagement"
management_key_vault_name = "my-redpandavault"
Expand Down Expand Up @@ -306,7 +311,7 @@ cat > redpanda-network.json <<EOF
"rp_0_pods" : { "name" : "$rp_0_pods_subnet_name" },
"rp_0_vnet" : { "name" : "$rp_0_vnet_subnet_name" },
"rp_1_pods" : { "name" : "$rp_1_pods_subnet_name" },
"rp_1_vnet" : { "name" : "$rp_2_vnet_subnet_name" },
"rp_1_vnet" : { "name" : "$rp_1_vnet_subnet_name" },
"rp_2_pods" : { "name" : "$rp_2_pods_subnet_name" },
"rp_2_vnet" : { "name" : "$rp_2_vnet_subnet_name" },
"rp_connect_pods" : { "name" : "$rp_connect_pods_subnet_name" },
Expand Down Expand Up @@ -380,11 +385,13 @@ cat > redpanda-cluster.json <<EOF
"user_assigned_identities" : {
"agent_user_assigned_identity": { "name" : "$agent_user_assigned_identity_name" },
"aks_user_assigned_identity": { "name" : "$aks_user_assigned_identity_name" },
"cert_manager_assigned_identity": { "name" : "$cert_manager_assigned_identity_name" },
"external_dns_assigned_identity": { "name" : "$external_dns_assigned_identity_name" },
"redpanda_cluster_assigned_identity": { "name" : "$redpanda_cluster_assigned_identity_name" },
"redpanda_console_assigned_identity": { "name" : "$redpanda_console_assigned_identity_name" },
"kafka_connect_assigned_identity": { "name" : "$kafka_connect_assigned_identity_name" }
"cert_manager_assigned_identity": { "name" : "$cert_manager_user_assigned_identity_name" },
"external_dns_assigned_identity": { "name" : "$external_dns_user_assigned_identity_name" },
"redpanda_cluster_assigned_identity": { "name" : "$cluster_user_assigned_identity_name" },
"redpanda_console_assigned_identity": { "name" : "$console_user_assigned_identity_name" },
"kafka_connect_assigned_identity": { "name" : "$kafka_connect_user_assigned_identity_name" },
"redpanda_connect_assigned_identity": { "name" : "$redpanda_connect_user_assigned_identity_name" },
"redpanda_connect_api_assigned_identity": { "name" : "$redpanda_connect_api_user_assigned_identity_name" }
}
}
}
Expand Down