Add Next Protocol Negotiation functions for OpenSSL #857
Conversation
|
Can one of the admins verify this patch? |
|
I wonder if this works for me... |
|
ok to test |
There was a problem hiding this comment.
Can you remove the names (ssl, out, outlen etc) from these too please?
There was a problem hiding this comment.
Do you just want them removed from the arguments to the function pointer, or from all the arguments to the function?
There was a problem hiding this comment.
Alllll of them. Like you did down here https://github.com/pyca/cryptography/pull/857/files#diff-15d99377d55eac8f33d06a1b1a62b323R467
|
Doesn't look like it :( |
|
Looks to be building to me. =) |
|
Not on Jenkins :( https://jenkins.cryptography.io/ |
|
=( That's OK, there's gotta be at least one more round of fixes, OpenSSL 0.9.8 doesn't like this at all. |
There was a problem hiding this comment.
You didn't fully functionpointerise this one :)
There was a problem hiding this comment.
Aha, good spot, thankyou! =)
|
For obvious reasons I'll squash all of these commits down when the build finishes. |
|
ok to test |
|
Test PASSed. |
There was a problem hiding this comment.
Nitpick, but the space between (*) and (SSL *, should be removed (and the alignment adjusted on the subsequent lines).
|
Other than my tiny style nits this looks good. Unfortunately |
|
@reaperhunk Those nits fixed in 9341ddc. |
|
Thanks @Lukasa as soon as tests pass I'll merge. |
|
Test PASSed. |
Add Next Protocol Negotiation functions for OpenSSL
4 participants
Next Protocol Negotiation was added in OpenSSL 1.0.1. This pull request would expose the necessary functions for use in pyca/pyopenssl#79.
I've had some testing 'fun' with this, probably because I've got no experience with CFFI or with OpenSSL. I'm opening this PR to see whether your CI infrastructure likes it or not. If it doesn't, I'll try to chase down why.