Skip to content

Add ALPN support.#1105

Merged
public merged 1 commit intopyca:masterfrom
Lukasa:alpn
Jun 7, 2014
Merged

Add ALPN support.#1105
public merged 1 commit intopyca:masterfrom
Lukasa:alpn

Conversation

@Lukasa
Copy link
Member

@Lukasa Lukasa commented Jun 7, 2014

ALPN support has been added in OpenSSL version 1.0.2, currently available in beta. This pull request would expose the necessary functions for use in pyca/pyopenssl#79.

This is naturally a follow-on pull request from #857.

@jenkins-cryptography
Copy link

Can one of the admins verify this patch?

@Lukasa
Copy link
Member Author

Lukasa commented Jun 7, 2014

Well that went badly. Let's pretend I never made that trivial mistake and try again.

@public
Copy link
Member

public commented Jun 7, 2014

ok to test

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 424c0e9 on Lukasa:alpn into a5f37b2 on pyca:master.

@jenkins-cryptography
Copy link

Test PASSed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1936/

@Lukasa
Copy link
Member Author

Lukasa commented Jun 7, 2014

So, one OS X run failed but that doesn't seem to be my fault: something went wrong with installing six.

@public
Copy link
Member

public commented Jun 7, 2014

I'm rerunning that one. Will merge when it passes.

public added a commit that referenced this pull request Jun 7, 2014
@public public merged commit a6d39a6 into pyca:master Jun 7, 2014
@Lukasa
Copy link
Member Author

Lukasa commented Jun 7, 2014

Thanks @public! =)

@Lukasa Lukasa deleted the alpn branch June 7, 2014 11:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants