-
Notifications
You must be signed in to change notification settings - Fork 422
Add support for Next Protocol Negotiation. #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you add a link to the cryptography pull request that introduces the necessary features? This will make it easier to figure out what release of cryptography this will depend on. |
|
Of course, it's pyca/cryptography#857. |
|
So the current cryptography master appears to pass (according to Travis) except on 3.2, which fails for reasons unrelated to my change. =) |
|
@Lukasa Excited to see NPN to get into pyopenssl. |
|
The release has happened, so this should work now. |
|
👍 Thanks for your help @alex! |
|
@exarkun What can I do to help move this forward now that cryptograpy has a release with the needed bindings? =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to make Next Protocol Negotiation a link to a document about that concept. Super nice would be a pyOpenSSL-internal doc explaining all the pieces of NPN but considering NPN is kind of obsolete already and there isn't already such a doc, an external link would probably have the best cost/benefit ratio.
|
Thanks for your work on this Lukasa. Sorry I didn't get back to you with feedback sooner. In addition to my inline comments, could you also add documentation for the new methods to Also, if you wouldn't mind closing this PR and re-opening it using a branch with a different name than "master" that would be wonderful. Thanks again. |
|
@exarkun No problem. =) There wouldn't have been a great deal to gain before now anyway, since it was all writing against bindings that didn't exist. I'll handle the markups in the next couple of days. I'm super busy at the minute but this is a high priority for me (I need it for one of my OSS projects), so I won't let this languish for long. |
This is part of #79.
This is my attempt to remain in the spirit of PyOpenSSL by making a minimal wrapper around OpenSSL's callback logic. As you can see, minimal is not my strong suit. Feedback would be appreciated. =D
Note: this will probably fail automated testing at the moment, as it relies on features that aren't yet in the current
cryptographyrelease. Passes on my machine on 2.7.