Speck setprops fix

[shammamah-zz]

About

• This is a new component
• I am adding a feature to an existing component, or improving an existing feature
• I am closing an issue

Description of changes

Remove all "unprotected" calls to setProps, which is only defined as a function if there is a callback in the Dash app that uses the component as input. Also ensure that view has a full set of parameters at any given time (before, it would be restricted to the dictionary supplied by the user and there would be errors related to not being able to compute the rendering because of missing properties).

Before merging

• I have gone through the code review checklist
• I have completed all of the steps to take before merging
• I know how to deploy to DDS

[mkcor]

I'm on https://dash-bio-test-pr-241.herokuapp.com/dash-bio/speck but I don't know how to test or experience the change: As a user, where can I supply a dictionary? What kind of dictionary?

[shammamah-zz]

@mkcor Sorry about that! Basically, the dictionary values are set by the controls in the app (so, things like "atom size", "ambient occlusion", etc.) -- this doesn't really affect the app itself, since I do have callbacks that take the speck component as input (

dash-bio/tests/dashbio_demos/app_speck.py

Line 260 in 4ea56b1

@app.callback(

). (But now that you mention it -- I should try to remove that callback/dcc.Store component and see if it still works.)

[Bachibouzouk]

Nice work!
💃

I noticed that the app had troubles which I will describe in the conversation

[mkcor]

@shammamah ok, right, the end user never passes a dict (explicitly) as an input. Feel free to poke me when the PR is ready for final review!

[mkcor]

I can't approve as long as there are merge conflicts. I'm happy to resolve them if you let me work on your branch. Let me know.

[shammamah-zz]

@mkcor This branch is still in progress! I'll ping you when it's ready :)

[alexcjohnson]

This fix will become moot in the next dash release (cc @Marc-Andre-Rivet ) plotly/dash-renderer#126

[mkcor]

Oh, okay!

[shammamah-zz]

@mkcor We should get this merged in anyway, since it fixes the issue with view as well -- please approve if you agree!

[mkcor]

Wait, I'm confused because this PR seems to contain these commits as well: https://github.com/plotly/dash-bio/pull/296/commits
I would be in favour of closing this PR (unmerged) and updating dependency dash-renderer==0.18.0 to the latest version (see @alexcjohnson's comment) and take it from there...

[shammamah-zz]

Closing this PR in light of the updates to dash-renderer that will make part of this fix redundant.