Speck setprops fix

CHANGELOG.md

@@ -4,6 +4,8 @@
 
 ### Fixed
 * Fixed issue with Clustergram not reordering rows and columns after clustering.
+* Fixed issue with Speck not properly handling incomplete "view" parameters.
+* Fixed issue with Speck not having setProps defined.
 
 ### Removed
 * Removed mentions of Dash events in OncoPrint component.

dash_bio/Ideogram.py

@@ -9,7 +9,7 @@ class Ideogram(Component):
 datasets for organisms such as human, mouse, and any other
 eukaryote. The Ideogram component can be used to compare
 homologous features between chromosomes, and depict
-haploid, diploid, aneuploidy genomes. It can also display
+haploid, diploid, aneuploid genomes. It can also display
 annotations on genomic data using histograms and overlays.
 
 Reference: https://eweitz.github.io/ideogram/

dash_bio/metadata.json

@@ -1183,7 +1183,7 @@
     }
   },
   "src/lib/components/Ideogram.react.js": {
-    "description": "The Ideogram component is used to draw and animate genome-wide\ndatasets for organisms such as human, mouse, and any other\neukaryote. The Ideogram component can be used to compare\nhomologous features between chromosomes, and depict\nhaploid, diploid, aneuploidy genomes. It can also display\nannotations on genomic data using histograms and overlays.\n\nReference: https://eweitz.github.io/ideogram/\nComponent's props: https://github.com/eweitz/ideogram/blob/master/api.md",
+    "description": "The Ideogram component is used to draw and animate genome-wide\ndatasets for organisms such as human, mouse, and any other\neukaryote. The Ideogram component can be used to compare\nhomologous features between chromosomes, and depict\nhaploid, diploid, aneuploid genomes. It can also display\nannotations on genomic data using histograms and overlays.\n\nReference: https://eweitz.github.io/ideogram/\nComponent's props: https://github.com/eweitz/ideogram/blob/master/api.md",
     "displayName": "Ideogram",
     "methods": [
       {

dash_bio/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dash-bio",
-  "version": "0.0.8-rc13",
+  "version": "0.0.8-rc14",
   "description": "Dash components for bioinformatics",
   "main": "build/index.js",
   "scripts": {
@@ -33,7 +33,7 @@
   "devDependencies": {
     "babel-core": "^6.26.3",
     "babel-eslint": "^10.0.0",
-    "babel-loader": "^8.0.0",
+    "babel-loader": "^7.0.0",
     "babel-preset-env": "^1.7.0",
     "babel-preset-react": "^6.24.1",
     "copyfiles": "^2.0.0",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "dash-bio",
-  "version": "0.0.8-rc13",
+  "version": "0.0.8-rc14",
   "description": "Dash components for bioinformatics",
   "main": "build/index.js",
   "scripts": {
@@ -33,7 +33,7 @@
   "devDependencies": {
     "babel-core": "^6.26.3",
     "babel-eslint": "^10.0.0",
-    "babel-loader": "^8.0.0",
+    "babel-loader": "^7.0.0",
     "babel-preset-env": "^1.7.0",
     "babel-preset-react": "^6.24.1",
     "copyfiles": "^2.0.0",

requirements.txt

@@ -6,7 +6,7 @@ biopython
 colour==0.1.5
 cython>=0.19
 dash==0.37.0
-dash-bio==0.0.8rc13
+dash-bio==0.0.8rc14
 dash-core-components==0.43.1
 dash-daq==0.1.4
 dash-html-components==0.13.5

src/lib/components/Speck.react.js

@@ -22,7 +22,7 @@ export default class Speck extends Component {
         speckSystem.calculateBonds(system);
 
         const renderer = this.state.renderer;
-        const view = this.props.view;
+        const view = Object.assign(speckView.new(), this.props.view);
 
         renderer.setSystem(system, view);
 
@@ -42,6 +42,9 @@ export default class Speck extends Component {
                     refreshView: false,
                 });
             }
+
+            // fill in any missing view properties
+            this.props.view = Object.assign(speckView.new(), this.props.view);
             this.state.renderer.render(this.props.view);
         }
         requestAnimationFrame(this.loop);
@@ -90,10 +93,13 @@ export default class Speck extends Component {
                     data[propertyName] !== nextProps.data[propertyName]
             )
         ) {
-            this.props.setProps({
-                data: nextProps.data,
-            });
-
+            if (this.props.setProps) {
+                this.props.setProps({
+                    data: nextProps.data,
+                });
+            } else {
+                this.props.data = nextProps.data;
+            }
             needsUpdate = true;
         }
 
@@ -103,9 +109,13 @@ export default class Speck extends Component {
                 view,
                 speckPresetViews[nextProps.presetView]
             );
-            this.props.setProps({
-                view: v,
-            });
+            if (this.props.setProps) {
+                this.props.setProps({
+                    view: v,
+                });
+            } else {
+                this.props.view = v;
+            }
 
             needsUpdate = true;
         }
@@ -119,9 +129,13 @@ export default class Speck extends Component {
             )
         ) {
             const v = Object.assign(view, nextProps.view);
-            this.props.setProps({
-                view: v,
-            });
+            if (this.props.setProps) {
+                this.props.setProps({
+                    view: v,
+                });
+            } else {
+                this.props.view = v;
+            }
 
             needsUpdate = true;
         }