Skip to content

Dash renderer update#297

Merged
shammamah-zz merged 9 commits intomasterfrom
dash-renderer-update
Apr 1, 2019
Merged

Dash renderer update#297
shammamah-zz merged 9 commits intomasterfrom
dash-renderer-update

Conversation

@shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented Apr 1, 2019

(note that I am not publishing a new version of the package, since the problem with Speck's view prop from #241 still needs to be fixed)

About

Updates to dash and dash-renderer ensure that setProps does not have to be defined by creating a callback that takes the component as input. This fixes part of the issue referenced in #241.

Description of changes

  • Change the Dash version in the requirements for the demo apps and in the setup install requirements for Dash Bio.
  • Change the demo apps to have default tabs, as the newest version of dash-core-components does not display the contents of the first tab by default.
  • Make the IDs for the tabs in each of the demo apps more uniform.
  • Remove unnecessary callback in Speck application.

Before merging

@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-297 April 1, 2019 19:15 Inactive
Dash comes with version 3.6.0 and not 3.4.0 as specified in the requirements file, which was causing conflicts.
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-297 April 1, 2019 19:18 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-297 April 1, 2019 19:20 Inactive
The new version of dash-core-components, or dash-renderer, was causing the tab content area to be empty; specifying a default tab fixes this.
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-297 April 1, 2019 19:35 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-297 April 1, 2019 19:38 Inactive
@shammamah-zz shammamah-zz requested a review from mkcor April 1, 2019 19:38
Since setProps no longer has to be defined, the dummy callback for Speck can be removed.
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-297 April 1, 2019 19:50 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-297 April 1, 2019 19:52 Inactive
Dash core libraries are installed by default upon installation of Dash.
@shammamah-zz shammamah-zz merged commit 8941cec into master Apr 1, 2019
@shammamah-zz shammamah-zz deleted the dash-renderer-update branch April 1, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants