Skip to content

[release-4.13] OCPBUGS-8493: Use lower case node names only#1454

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1453-to-release-4.13
Mar 8, 2023
Merged

[release-4.13] OCPBUGS-8493: Use lower case node names only#1454
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1453-to-release-4.13

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 7, 2023

This is an automated cherry-pick of #1453

/assign pacevedom

@pacevedom
OCPBUGS-8411: Use lower case node names only
2fc688e 
While hostnames may have whatever case is desired by the user, resources
in kubernetes must be lower case. Node name was directly copied from the
hostname, resulting in upper case characters, if any. This prevents creation
of the node and many other interactions between kubelet and apiserver.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 7, 2023
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 7, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-8411 has been cloned as Jira Issue OCPBUGS-8493. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-8493: Use lower case node names only

Details

In response to this:

This is an automated cherry-pick of #1453

/assign pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-8411: Use lower case node names only [release-4.13] OCPBUGS-8493: Use lower case node names only Mar 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] OCPBUGS-8493: Use lower case node names only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 7, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-8493, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8411 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-8411 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1453

/assign pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jogeo, oglok and sallyom March 7, 2023 14:15
@ggiguash
Copy link
Contributor

ggiguash commented Mar 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@pacevedom
Copy link
Contributor

pacevedom commented Mar 7, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-router-smoke-test 2fc688e link false /test e2e-router-smoke-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacevedom
Copy link
Contributor

pacevedom commented Mar 7, 2023

/retest-required

@pacevedom
Copy link
Contributor

pacevedom commented Mar 7, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 7, 2023
@jogeo
Copy link
Contributor

jogeo commented Mar 8, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 90216af into openshift:release-4.13 Mar 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 8, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-8493: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-8493 has not been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1453

/assign pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash ggiguash mentioned this pull request Mar 8, 2023
Closed
@pacevedom
Copy link
Contributor

pacevedom commented Mar 10, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2023

@pacevedom: Jira Issue OCPBUGS-8493: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-8493 has not been moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacevedom
Copy link
Contributor

pacevedom commented Mar 10, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2023

@pacevedom: Jira Issue OCPBUGS-8493: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8493 has been moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@oglok oglok Awaiting requested review from oglok

@sallyom sallyom Awaiting requested review from sallyom

Assignees

@mffiedler mffiedler

@jhou1 jhou1

@zhaozhanqi zhaozhanqi

@jogeo jogeo

@xingxingxia xingxingxia

@anuragthehatter anuragthehatter

@wangke19 wangke19

@pacevedom pacevedom

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.