Skip to content

[release-4.12] Use lower case node names only#1470

Closed
AllenZMC wants to merge 1 commit intoopenshift:release-4.12from
AllenZMC:fix_hostname
Closed

[release-4.12] Use lower case node names only#1470
AllenZMC wants to merge 1 commit intoopenshift:release-4.12from
AllenZMC:fix_hostname

Conversation

@AllenZMC
Copy link

@AllenZMC AllenZMC commented Mar 8, 2023

Which issue(s) this PR addresses:
#1449

Closes #

While hostnames may have whatever case is desired by the user, resources
in kubernetes must be lower case. Node name was directly copied from the
hostname, resulting in upper case characters, if any. This prevents creation
of the node and many other interactions between kubelet and apiserver.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

@AllenZMC: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] Use lower case node names only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

@AllenZMC: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] Use lower case node names only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dhellmann and stlaz March 8, 2023 12:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AllenZMC
Once this PR has been reviewed and has the lgtm label, please assign stlaz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

Hi @AllenZMC. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor

ggiguash commented Mar 8, 2023

@AllenZMC , thank you for opening this PR.
I discussed it with the team and we would like to avoid backporting this functionality into 4.12 release because it's not a critical problem with an easy workaround. We encourage users to utilize the main branch or the 4.13 release targeted in a few weeks.

We already have a PR #1454 open to port this fix into the 4.13 release, so you should be able to take advantage of that. Note that you can use MicroShift 4.13 engineering candidate builds from https://mirror.openshift.com/pub/openshift-v4/x86_64/microshift/ocp-dev-preview/latest-4.13/ before we officially release this code in rhocp-4.13 channel

I'm closing this PR due to the above
/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

@ggiguash: Closed this PR.

Details

In response to this:

@AllenZMC , thank you for opening this PR.
I discussed it with the team and we would like to avoid backporting this functionality into 4.12 release because it's not a critical problem with an easy workaround. We encourage users to utilize the main branch or the 4.13 release targeted in a few weeks.

We already have a PR #1454 open to port this fix into the 4.13 release, so you should be able to take advantage of that. Note that you can use MicroShift 4.13 engineering candidate builds from https://mirror.openshift.com/pub/openshift-v4/x86_64/microshift/ocp-dev-preview/latest-4.13/ before we officially release this code in rhocp-4.13 channel

I'm closing this PR due to the above
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AllenZMC AllenZMC deleted the fix_hostname branch March 8, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants