[release-4.12] OCPBUGS-8411: Use lower case node names only by AllenZMC · Pull Request #1465 · openshift/microshift

AllenZMC · 2023-03-08T07:39:42Z

cherry-pick of #1453

While hostnames may have whatever case is desired by the user, resources in kubernetes must be lower case. Node name was directly copied from the hostname, resulting in upper case characters, if any. This prevents creation of the node and many other interactions between kubelet and apiserver.

openshift-ci · 2023-03-08T07:39:45Z

@AllenZMC: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8411: Use lower case node names only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-08T07:39:47Z

@AllenZMC: This pull request references Jira Issue OCPBUGS-8411, which is invalid:

expected the bug to target the "4.12.z" version, but it targets "4.14.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
expected Jira Issue OCPBUGS-8411 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

cherry-pick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-08T07:40:13Z

Hi @AllenZMC. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-08T07:40:19Z

@AllenZMC: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

cherry-pick for release-4.12, OCPBUGS-8411: Use lower case node names only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-08T07:43:20Z

@AllenZMC: This pull request references Jira Issue OCPBUGS-8411, which is invalid:

expected the bug to target the "4.12.z" version, but it targets "4.14.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
expected Jira Issue OCPBUGS-8411 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

cherry-pick of #1453

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-08T07:43:51Z

@AllenZMC: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

cherry-pick for release-4.12, OCPBUGS-8411: Use lower case node names only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-08T07:44:15Z

@AllenZMC: This pull request references Jira Issue OCPBUGS-8493, which is invalid:

expected the bug to target the "4.12.z" version, but it targets "4.13.0" instead
expected dependent Jira Issue OCPBUGS-8411 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead
expected dependent Jira Issue OCPBUGS-8411 to target a version in 4.13.0, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

cherry-pick of #1453

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-08T07:44:22Z

@AllenZMC: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-8493: Use lower case node names only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-08T08:51:02Z

@AllenZMC: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-8411: Use lower case node names only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-08T08:51:03Z

@AllenZMC: This pull request references Jira Issue OCPBUGS-8411, which is invalid:

expected the bug to target the "4.12.z" version, but it targets "4.14.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
expected Jira Issue OCPBUGS-8411 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

cherry-pick of #1453

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AllenZMC · 2023-03-08T08:52:02Z

/jira refresh

openshift-ci-robot · 2023-03-08T08:52:04Z

@AllenZMC: This pull request references Jira Issue OCPBUGS-8411, which is invalid:

expected the bug to target the "4.12.z" version, but it targets "4.14.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
expected Jira Issue OCPBUGS-8411 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This reverts commit cc04a43.

openshift-ci · 2023-03-08T11:57:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AllenZMC

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-03-08T11:57:20Z

@AllenZMC: This pull request references Jira Issue OCPBUGS-8411. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

cherry-pick of #1453

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from oglok and pmtk March 8, 2023 07:40

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 8, 2023

AllenZMC changed the title ~~OCPBUGS-8411: Use lower case node names only~~ cherry-pick for release-4.12, OCPBUGS-8411: Use lower case node names only Mar 8, 2023

AllenZMC changed the title ~~cherry-pick for release-4.12, OCPBUGS-8411: Use lower case node names only~~ [release-4.12] OCPBUGS-8493: Use lower case node names only Mar 8, 2023

AllenZMC mentioned this pull request Mar 8, 2023

[Bug] Microshift does not come up if the Hostname has an upper case letter #1449

Closed

AllenZMC changed the title ~~[release-4.12] OCPBUGS-8493: Use lower case node names only~~ [release-4.12] OCPBUGS-8411: Use lower case node names only Mar 8, 2023

Revert "OCPBUGS-8411: Use lower case node names only"

a7a181c

This reverts commit cc04a43.

AllenZMC closed this Mar 8, 2023

AllenZMC deleted the fix_hostname branch March 8, 2023 11:57

openshift-ci-robot mentioned this pull request Mar 8, 2023

[release-4.13] OCPBUGS-8493: Use lower case node names only #1454

Merged

microshift-rebase-script bot mentioned this pull request Nov 13, 2024

NO-ISSUE: rebase-main-4.18.0-0.nightly-2024-11-12-201730_amd64-2024-11-12_arm64-2024-11-12 #4171

Closed

This was referenced Nov 14, 2024

NO-ISSUE: rebase-main-4.18.0-0.nightly-2024-11-13-182254_amd64-2024-11-13_arm64-2024-11-13 #4175

Closed

NO-ISSUE: rebase-main-4.18.0-0.nightly-2024-11-15-113437_amd64-2024-11-15_arm64-2024-11-17 #4194

Merged

Conversation

AllenZMC commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 8, 2023

Uh oh!

openshift-ci-robot commented Mar 8, 2023

Uh oh!

openshift-ci bot commented Mar 8, 2023

Uh oh!

openshift-ci bot commented Mar 8, 2023

Uh oh!

openshift-ci-robot commented Mar 8, 2023

Uh oh!

openshift-ci bot commented Mar 8, 2023

Uh oh!

openshift-ci-robot commented Mar 8, 2023

Uh oh!

openshift-ci bot commented Mar 8, 2023

Uh oh!

openshift-ci bot commented Mar 8, 2023

Uh oh!

openshift-ci-robot commented Mar 8, 2023

Uh oh!

AllenZMC commented Mar 8, 2023

Uh oh!

openshift-ci-robot commented Mar 8, 2023

Uh oh!

openshift-ci bot commented Mar 8, 2023

Uh oh!

openshift-ci-robot commented Mar 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AllenZMC commented Mar 8, 2023 •

edited

Loading