Fix(debug): remove component in beforeDestroy hook#6737
Merged
max-nextcloud merged 1 commit intomainfrom Dec 8, 2024
Merged
Conversation
max-nextcloud
requested review from
juliusknorr and
mejo-
and removed request for
mejo-
juliusknorr
approved these changes
Dec 5, 2024
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Nice, thanks for pulling that out of Editor.vue as well ;)
* Use a set so components can only be in there once. * Debug data can be written even if syncService is undefined. Signed-off-by: Max <max@nextcloud.com>
juliusknorr
force-pushed
the
fix/debug-yjs
branch
from
5b6b9da to
40df45e
Compare
Collaborator
Author
|
/backport to stable30 |
Collaborator
Author
|
/backport to stable29 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)