[stable30] Fix(debug): remove component in beforeDestroy hook#6757
Merged
juliusknorr merged 1 commit intostable30from Dec 13, 2024
Merged
[stable30] Fix(debug): remove component in beforeDestroy hook#6757juliusknorr merged 1 commit intostable30from
juliusknorr merged 1 commit intostable30from
Conversation
max-nextcloud
requested changes
Dec 9, 2024
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Let's wait for the NC 30 bugfix release.... other than that the backport seems fine.
This was referenced Dec 9, 2024
* Use a set so components can only be in there once. * Debug data can be written even if syncService is undefined. Signed-off-by: Max <max@nextcloud.com>
juliusknorr
force-pushed
the
backport/6737/stable30
branch
from
03622ba to
7a5b46a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable30 #6757 +/- ##
=========================================
Coverage 53.60% 53.60%
=========================================
Files 116 116
Lines 2580 2580
Branches 526 526
=========================================
Hits 1383 1383
Misses 1069 1069
Partials 128 128 ☔ View full report in Codecov by Sentry. |
juliusknorr
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6737