[stable29] Fix(debug): remove component in beforeDestroy hook#6756
Merged
[stable29] Fix(debug): remove component in beforeDestroy hook#6756
Conversation
057d489 to
ede111d
Compare
* Use a set so components can only be in there once. * Debug data can be written even if syncService is undefined. Signed-off-by: Max <max@nextcloud.com> Signed-off-by: Max <max@nextcloud.com>
ede111d to
3aa227e
Compare
max-nextcloud
approved these changes
Dec 9, 2024
Collaborator
max-nextcloud
left a comment
There was a problem hiding this comment.
Fixed the backport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6737
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.