Fix direct editing loading of txt files#3476
Conversation
|
@max-nextcloud those were the changes from our earlier debugging session. Will add a cypress test later for this as well. |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
I also figured out why the session id is being regenerated. It seems that the user id is now written to the session (which was not before 25) due to the fact that we change into the user scope. First attempt to properly address this is in nextcloud/server#35360 |
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Looks good. Minimal change, hopefully easy to backport to 25.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/txt-direct
branch
from
0ebd6e9 to
ca98523
Compare
|
/compile |
|
/backport to stable25 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
|
The backport to stable25 failed. Please do this backport manually. |
1 similar comment
3 participants
📝 Summary
Fix loading txt files through direct editing
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)