[stable25] Fix direct editing loading of txt files#3479
[stable25] Fix direct editing loading of txt files#3479juliusknorr merged 2 commits intostable25from
Conversation
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
| document: this.document, | ||
| session: this.session, | ||
| documentSource: '' + content, | ||
| documentSource: '' + connectionData.content, |
There was a problem hiding this comment.
Isn't this the same thing we removed above? I'm confused. 😅
There was a problem hiding this comment.
Yes, which is fine still just without the fetch fallback
There was a problem hiding this comment.
The main problem was that an empty string (from a file without content) would always trigger the fetch request which is actually not necessary anymore as we always pass the content earlier.
| document: this.document, | ||
| session: this.session, | ||
| documentSource: '' + content, | ||
| documentSource: '' + connectionData.content, |
There was a problem hiding this comment.
Minor nitpick, but could we just cast it?
documentSource: String(connectionData.content)There was a problem hiding this comment.
Nevermind, this is already a backport 🙈
Approved
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
backport/3476/stable25
branch
from
aafbe2f to
8ab2a53
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
5 participants
Backport of #3476