Fix overwriteService() for apps

[nickvergessen]

Fix #21809 (comment)

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31141: failure

integration-auth

• build/integration/features/auth.feature:70

Show full log

  Scenario: using OCS anonymously                                                    # /drone/src/build/integration/features/auth.feature:70
[Tue Jul 28 07:44:04 2020] 127.0.0.1:49402 [404]: /ocs/v2.php/cloud/users/user0
[Tue Jul 28 07:44:04 2020] 127.0.0.1:49426 [200]: /ocs/v1.php/cloud/users
[Tue Jul 28 07:44:05 2020] 127.0.0.1:49486 [200]: /ocs/v1.php/cloud/users/user0
[Tue Jul 28 07:44:05 2020] 127.0.0.1:49510 [200]: /ocs/v2.php/cloud/users/user0
[Tue Jul 28 07:44:05 2020] 127.0.0.1:49528 [200]: /login
[Tue Jul 28 07:44:06 2020] 127.0.0.1:49534 [303]: /login
[Tue Jul 28 07:44:06 2020] 127.0.0.1:49560 [200]: /index.php/apps/files/
[Tue Jul 28 07:44:06 2020] 127.0.0.1:49564 [200]: /index.php/settings/personal/authtokens
[Tue Jul 28 07:44:06 2020] 127.0.0.1:49574 [200]: /index.php/settings/personal/authtokens/56
[Tue Jul 28 07:44:06 2020] 127.0.0.1:49578 [303]: /login
[Tue Jul 28 07:44:06 2020] 127.0.0.1:49584 [200]: /index.php/apps/files/
[Tue Jul 28 07:44:06 2020] 127.0.0.1:49588 [303]: /login
[Tue Jul 28 07:44:06 2020] 127.0.0.1:49608 [200]: /index.php/apps/files/
[Tue Jul 28 07:44:07 2020] 127.0.0.1:49614 [200]: /index.php/settings/personal/authtokens
[Tue Jul 28 07:44:07 2020] TypeError: Argument 11 passed to OCA\Files_Sharing\External\Manager::__construct() must be of the type string, null given, called in /drone/src/apps/files_sharing/lib/AppInfo/Application.php on line 98 at /drone/src/apps/files_sharing/lib/External/Manager.php#91
[Tue Jul 28 07:44:07 2020] 127.0.0.1:49624 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares
    When requesting "/ocs/v1.php/apps/files_sharing/api/v1/remote_shares" with "GET" # FeatureContext::requestingWith()
    Then the OCS status code should be "997"                                         # FeatureContext::theOCSStatusCodeShouldBe()
      Notice: Trying to get property 'meta' of non-object in /drone/src/build/integration/features/bootstrap/BasicStructure.php line 153
[Tue Jul 28 07:44:07 2020] 127.0.0.1:49630 [200]: /ocs/v1.php/cloud/users/user0
[Tue Jul 28 07:44:08 2020] 127.0.0.1:49658 [404]: /ocs/v2.php/cloud/users/user0
[Tue Jul 28 07:44:08 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Tue Jul 28 07:44:08 2020] 127.0.0.1:49670 [401]: /remote.php/webdav/myFileToComment.txt
[Tue Jul 28 07:44:08 2020] 127.0.0.1:49674 [207]: /remote.php/dav/systemtags/
[Tue Jul 28 07:44:08 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Tue Jul 28 07:44:08 2020] 127.0.0.1:49690 [401]: /remote.php/webdav/myFileToTag.txt
[Tue Jul 28 07:44:08 2020] 127.0.0.1:49694 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Tue Jul 28 07:44:09 2020] 127.0.0.1:49714 [404]: /remote.php/dav/calendars/admin/MyCalendar

[danxuliu]

Talk unit tests work again with this 👍

Regarding the changes, 🐘 (I would prefer a fix that does not involve exposing a private method, but I guess it is not possible 🤷)

The integration test failure is unrelated (it fails too in bugfix/noid/fix-overwrite-service-for-apps^).

[MorrisJobke]

Not the best to expose something internal, but it is private namespace anyways 👍