Handle referenceId for system messages e.g. when uploading a file#3948
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
268563d to
bbd1b90
Compare
|
Failing unit tests are fixed with nextcloud/server#22027 |
danxuliu
left a comment
There was a problem hiding this comment.
Tested and works 👍
One little thing that I have noticed: if you upload a large file and send new messages while the file is being uploaded the file will appear after those messages. Honestly I do not know if a user would expect the file to appear in the message list where it started to upload or where it ended to upload.
Also I guess that to change the behaviour some more hacks will be needed to explicitly assign a date to system messages or something like that, so I do not know if it is worth the trouble. In any case, something for a follow up pull request I would say.
Hmm yeah well it's the same for when your sending a message takes longer the order could be different if you dont wait for the finishing. |
Signed-off-by: Joas Schilling coding@schilljs.com