Use PSR container interface and deprecate our own abstraction

[ChristophWurst]

For https://help.nextcloud.com/t/do-we-still-need-ocp-icontainer/86139

• Add the PSR-11 container interface as a replacement for IContainer
• Deprecate our IContainer and friends
• Make the new interface base of our abstraction to ease the migration
• Use composition instead of inheritance for SimpleContainer -> Pimple as that makes the abstraction leaner and will help with the migration later on.

• Requires Install the PSR-11 container 3rdparty#475 (though the interface was already there)

Docs are at nextcloud/documentation#2202

[rullzer]

Maybe I'm not 100% right with the PSR... but it seems has and get have clear defined meanings...

[ChristophWurst]

FYI one of my attempts was to get rid of Pimple and replace it with Symfony. But that container is not easy to use as it kind of expects to be first notified about all the known services, then compiled and finally used. But we have a more dynamic approach and allow registration later on. So I switched to the League container and that felt a lot more natural to our DI usage. However, the changes are major and we (@rullzer and I) think it would be a bad idea to cram this in so late in the 20 cycle. Thus this will be done for 21.

The important part is the new PSR API. That is done with this PR. So the migration can start.

[rullzer]

🚀

[ChristophWurst]

I don't see any files anymore 🙈 fixed

Let's see if CI can find the faults.

[MorrisJobke]

Fine by me 👍 Also changing to a PSR standard is the way to go

[nickvergessen]

This breaks apps ability to use overwriteService in unit tests :/
E.g. https://github.com/nextcloud/spreed/blob/31c20949b4132e0024446a30f0f3a423bf145906/tests/php/Signaling/BackendNotifierTest.php#L126 is currently failing

[MorrisJobke]

This breaks apps ability to use overwriteService in unit tests :/
E.g. https://github.com/nextcloud/spreed/blob/31c20949b4132e0024446a30f0f3a423bf145906/tests/php/Signaling/BackendNotifierTest.php#L126 is currently failing

So we need to adjust overwriteService to use the new approach, right?

[nickvergessen]

Yeah, fixed in #22027

[ChristophWurst]

Documented at nextcloud/documentation#5160