Skip to content

Add typed events for the filesystem/scanner#18351

Merged
blizzz merged 1 commit intomasterfrom
enhancement/typed-filesystem-events
Dec 13, 2019
Merged

Add typed events for the filesystem/scanner#18351
blizzz merged 1 commit intomasterfrom
enhancement/typed-filesystem-events

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 11, 2019

Continuation of #18348 and #18350.

For https://docs.nextcloud.com/server/stable/developer_manual/app/hooks.html#filesystem-scanner

  • scanFile (string $absolutePath)
  • scanFolder (string $absolutePath)
  • postScanFile (string $absolutePath)
  • postScanFolder (string $absolutePath)

File scanner and app dir scanner still work fine here. Let's see what CI thinks.

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Dec 11, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Dec 11, 2019
@ChristophWurst ChristophWurst self-assigned this Dec 11, 2019
ChristophWurst
ChristophWurst commented Dec 11, 2019
View reviewed changes
rullzer
rullzer approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you are missing the composer update ;)

lib/public/Files/Events/FolderScannedEvent.php
*
* @since 18.0.0
*/
public function __construct(string $absolutePath) {
Copy link
Member

@rullzer rullzer Dec 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These events are all rather similar...

For a followup we could merge them and just have them extend absract events? That way you could listen to a generatic BeforeScannedEvent?

@ChristophWurst ChristophWurst force-pushed the enhancement/typed-filesystem-events branch from d71b01e to 0ec640a Compare December 11, 2019 12:26
This was referenced Dec 12, 2019
Merged
Merged
@ChristophWurst ChristophWurst force-pushed the enhancement/typed-filesystem-events branch from 0ec640a to 199dd39 Compare December 12, 2019 13:42
@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 12, 2019
@rullzer
Copy link
Member

rullzer commented Dec 12, 2019

Tests do 💥

@rullzer rullzer added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Dec 12, 2019
@ChristophWurst
Add typed events for the filesystem/scanner
b81b824 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the enhancement/typed-filesystem-events branch from ef5db52 to b81b824 Compare December 13, 2019 08:41
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress 3. to review Waiting for reviews labels Dec 13, 2019
@blizzz blizzz merged commit ae6460c into master Dec 13, 2019
@blizzz blizzz deleted the enhancement/typed-filesystem-events branch December 13, 2019 11:47
MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke
Document existing events
da43209 
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke mentioned this pull request Aug 10, 2020
Merged
backportbot-nextcloud bot pushed a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke @backportbot
Document existing events
6ca7040 
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke
Document existing events
7e78e7e 
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke
Document existing events
6da5114 
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 29, 2020

ref #14552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst @rullzer @MorrisJobke @icewind1991 @blizzz