Conversation
juliusknorr
approved these changes
Dec 23, 2019
juliusknorr
requested changes
Dec 23, 2019
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
PHPDoc is needed for OCP\WorkflowEngine\Events\RegisterOperationsEvent::RegisterOperationsEvent
15 | PHPDoc is needed for OCP\WorkflowEngine\Events\RegisterOperationsEvent::__construct
16 | PHPDoc is needed for OCP\WorkflowEngine\Events\RegisterOperationsEvent::registerOperation
17 | PHPDoc is needed for OCP\WorkflowEngine\Events\RegisterChecksEvent::RegisterChecksEvent
18 | PHPDoc is needed for OCP\WorkflowEngine\Events\RegisterChecksEvent::__construct
19 | PHPDoc is needed for OCP\WorkflowEngine\Events\RegisterChecksEvent::registerCheck
20 | PHPDoc is needed for OCP\WorkflowEngine\Events\RegisterEntitiesEvent::RegisterEntitiesEvent
21 | PHPDoc is needed for OCP\WorkflowEngine\Events\RegisterEntitiesEvent::__construct
22 | PHPDoc is needed for OCP\WorkflowEngine\Events\RegisterEntitiesEvent::registerEntity
23
rullzer
force-pushed
the
enh/flow/newDispatcher
branch
from
7fecb05 to
39a597f
Compare
Member
Author
|
Fixed |
Member
|
Looks like the tests need fixing :) |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
enh/flow/newDispatcher
branch
from
39a597f to
25d4f32
Compare
Member
Author
|
And finally all fixed. |
Member
|
i'll review tomorrow |
MorrisJobke
added a commit
to nextcloud/documentation
that referenced
this pull request
Aug 10, 2020
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641 * LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271 * RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625 * typed events for files scanner (@ChristophWurst) - nextcloud/server#18351 * typed events for group mangement (@ChristophWurst) - nextcloud/server#18350 * AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730 * UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186 * password_policy events (@ChristophWurst) - nextcloud/server#18019 * AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613 * ShareCreatedEvent (@rullzer) - nextcloud/server#18384 * LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475 * flow events (@rullzer) - nextcloud/server#18535 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
backportbot-nextcloud bot
pushed a commit
to nextcloud/documentation
that referenced
this pull request
Aug 10, 2020
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641 * LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271 * RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625 * typed events for files scanner (@ChristophWurst) - nextcloud/server#18351 * typed events for group mangement (@ChristophWurst) - nextcloud/server#18350 * AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730 * UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186 * password_policy events (@ChristophWurst) - nextcloud/server#18019 * AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613 * ShareCreatedEvent (@rullzer) - nextcloud/server#18384 * LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475 * flow events (@rullzer) - nextcloud/server#18535 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added a commit
to nextcloud/documentation
that referenced
this pull request
Aug 10, 2020
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641 * LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271 * RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625 * typed events for files scanner (@ChristophWurst) - nextcloud/server#18351 * typed events for group mangement (@ChristophWurst) - nextcloud/server#18350 * AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730 * UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186 * password_policy events (@ChristophWurst) - nextcloud/server#18019 * AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613 * ShareCreatedEvent (@rullzer) - nextcloud/server#18384 * LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475 * flow events (@rullzer) - nextcloud/server#18535 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added a commit
to nextcloud/documentation
that referenced
this pull request
Aug 10, 2020
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641 * LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271 * RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625 * typed events for files scanner (@ChristophWurst) - nextcloud/server#18351 * typed events for group mangement (@ChristophWurst) - nextcloud/server#18350 * AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730 * UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186 * password_policy events (@ChristophWurst) - nextcloud/server#18019 * AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613 * ShareCreatedEvent (@rullzer) - nextcloud/server#18384 * LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475 * flow events (@rullzer) - nextcloud/server#18535 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMO the new events are much cleaner.
But lets be pragmatic and just emit both now and kill the legacy stuff for 19.