Add typed events for all user hooks and legacy events#18348
Merged
ChristophWurst merged 1 commit intomasterfrom Dec 11, 2019
Merged
Add typed events for all user hooks and legacy events#18348ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
ChristophWurst
added
enhancement
3. to review
ChristophWurst
requested review from
blizzz,
gary-kim,
georgehrke,
kesselb,
rullzer and
skjnldsv
georgehrke
reviewed
Dec 11, 2019
georgehrke
reviewed
Dec 11, 2019
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/typed-user-events-II
branch
from
c58f144 to
d808f9c
Compare
skjnldsv
approved these changes
Dec 11, 2019
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Crazy work!
We shall document this!
Member
Author
on my todo :) |
skjnldsv
added
the
pending documentation
This was referenced Dec 11, 2019
4 tasks
ChristophWurst
added
4. to release
ChristophWurst
removed
the
pending documentation
Member
|
ref #14552 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a lot of dark magic we use for user change propagation. That is why removing the emit stuff in #18225 failed on CI terribly. This needs a more in-depth analysis.
To still get the new events in for 18 I created a modified version where I leave the old mechanisms in place and just convert the old stuff to the new (and not the other way around). The cleanup will follow for 19.
Supersedes #18225.