This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Conversation
Contributor
Author
|
Looks like the circle ci status check is broken. Because this is a critical issue for some of our websites, I checked manually that tests are padding on CircleCi and I'm going to merge this pr. |
This was referenced Jan 16, 2020
Closed
bendvc
added a commit
that referenced
this pull request
Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the
refineproperty for various search type calls (searchProducts, searchContent) gets parsed into a CSV (e.g.color=blue,cgid=root). This behaviour worked fine when the client was originally generate even though it didn't follow the described behaviour as per the Salesforce doc's.There was an attempt to fix this in the following PR#2 but was abandoned in favour of leaving it and not touching the auto generated code, as it was still working.
It seems as tho Salesforce has discontinued this undocumented behaviour (I can only speculate that this is the cause). So this PR re-introduces that functionality provided by the PR linked above.
Note: A community member proposed a fix here.
Type of change
Changes
buildRefineParamsHow to test this PR?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration