Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Fix Refine Parsing for Various Calls#29

Merged
bendvc merged 7 commits intodevelopfrom
fix-refinements
Jan 15, 2020
Merged

Fix Refine Parsing for Various Calls#29
bendvc merged 7 commits intodevelopfrom
fix-refinements

Conversation

@bendvc
Copy link
Copy Markdown
Contributor

@bendvc bendvc commented Jan 15, 2020

By default the refine property for various search type calls (searchProducts, searchContent) gets parsed into a CSV (e.g. color=blue,cgid=root). This behaviour worked fine when the client was originally generate even though it didn't follow the described behaviour as per the Salesforce doc's.

There was an attempt to fix this in the following PR#2 but was abandoned in favour of leaving it and not touching the auto generated code, as it was still working.

It seems as tho Salesforce has discontinued this undocumented behaviour (I can only speculate that this is the cause). So this PR re-introduces that functionality provided by the PR linked above.

Note: A community member proposed a fix here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Changes

  • Add buildRefineParams
  • Update opt processing where required
  • Update docs
  • Update changelog

How to test this PR?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Copy link
Copy Markdown
Contributor

@olibrook olibrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bendvc
Copy link
Copy Markdown
Contributor Author

bendvc commented Jan 15, 2020

Looks like the circle ci status check is broken. Because this is a critical issue for some of our websites, I checked manually that tests are padding on CircleCi and I'm going to merge this pr.

@bendvc bendvc merged commit 298ff54 into develop Jan 15, 2020
bendvc added a commit that referenced this pull request Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants