Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Fix product search refinements#2

Closed
bendvc wants to merge 10 commits intodevelopfrom
fix-product-search-refinements
Closed

Fix product search refinements#2
bendvc wants to merge 10 commits intodevelopfrom
fix-product-search-refinements

Conversation

@bendvc
Copy link
Copy Markdown
Contributor

@bendvc bendvc commented Nov 7, 2017

Api called that used the 'refine' optional parameter didn't process the refine_1...refine_n options, only the 'refine' option. This pr updates the code so that those options are processed and sent to the server.

Status: Opened for visibility

Changes

  • Update product search call optional params parsing
  • Update content search call optional params parsing
  • Removed a incomplete test that had debugging logs in it
  • Update docs

@bendvc bendvc requested a review from kevinxh November 7, 2017 00:59
@bendvc
Copy link
Copy Markdown
Contributor Author

bendvc commented Nov 7, 2017

Comment, this change wasn't required. The client provided this functionality, I was just using it incorrectly.

@bendvc bendvc closed this Nov 7, 2017
@bendvc bendvc deleted the fix-product-search-refinements branch November 7, 2017 19:51
@kevinxh
Copy link
Copy Markdown
Contributor

kevinxh commented Nov 7, 2017

More note:

For SFCC OCAPI product search, we can use a comma to specify multiple refinements, i.e. refine=color=black,price=10.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants