Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Update refinement params#28

Closed
vcua-mobify wants to merge 2 commits intodevelopfrom
update-refinement-params
Closed

Update refinement params#28
vcua-mobify wants to merge 2 commits intodevelopfrom
update-refinement-params

Conversation

@vcua-mobify
Copy link
Copy Markdown

…f OCAPI

Description

From support ticket https://support.mobify.com/a/tickets/5541

This change modifies how refine parameters are set so that it matches the format outlined in https://documentation.b2c.commercecloud.salesforce.com/DOC4/index.jsp?topic=%2Fcom.demandware.dochelp%2FOCAPI%2F16.9%2Fshop%2FResources%2FProductSearch.html

That is: refine_1=, refine_2= rather than just separating with a comma.

Currently, the changes in this PR are applied in several places throughout ProductSearchAPI.js. We might be able to pull some of this into the SDK to avoid repetition.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How to test this PR?

The code itself is untested. The changes were tested in Postman to make sure this type of change would work.

Checklist:

  • My code follows the style guidelines of this project (npm run lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md and CHANGELOG.md)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (npm test)

@drewzboto
Copy link
Copy Markdown

@vcua-mobify Can we close this in favor on the newly merged #29?

@bendvc
Copy link
Copy Markdown
Contributor

bendvc commented Jan 17, 2020

Hey @vcua-mobify,

Thanks for the PR, we've gone ahead an created an merged a separate PR that fixes this issue here 👉 #29. This PR is similar to a closed PR here.

If you have any questions, feel free to reach out to me.

@bendvc bendvc closed this Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants