This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Closed
Conversation
|
@vcua-mobify Can we close this in favor on the newly merged #29? |
Contributor
|
Hey @vcua-mobify, Thanks for the PR, we've gone ahead an created an merged a separate PR that fixes this issue here 👉 #29. This PR is similar to a closed PR here. If you have any questions, feel free to reach out to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…f OCAPI
Description
From support ticket https://support.mobify.com/a/tickets/5541
This change modifies how refine parameters are set so that it matches the format outlined in https://documentation.b2c.commercecloud.salesforce.com/DOC4/index.jsp?topic=%2Fcom.demandware.dochelp%2FOCAPI%2F16.9%2Fshop%2FResources%2FProductSearch.html
That is:
refine_1=,refine_2=rather than just separating with a comma.Currently, the changes in this PR are applied in several places throughout ProductSearchAPI.js. We might be able to pull some of this into the SDK to avoid repetition.
Type of change
How to test this PR?
The code itself is untested. The changes were tested in Postman to make sure this type of change would work.
Checklist:
npm run lint)README.mdandCHANGELOG.md)npm test)