Conversation
Check if on default branch before uploading database
Provide a better error message
Only attempt to upload on dotcom
Add a CODEOWNERS file
Upload CodeQL databases
Revert "Upload CodeQL databases"
Mergeback v1.0.2 refs/heads/v1 into main
Upload CodeQL databases - mk2
Update CodeQL bundle to 20210622 / 2.5.6
The changelog for an empty version will now be: ``` No user facing changes. ``` And this will appear in the final changelog when there is an actual release. The benefits are that users will see regular release cycles and know how old versions are even if there's no changes for a particular version If we find that we are going months without any user facing changes, but we have non-visible changes, then we can rethink this strategy. But I think this is nicer than having empty sections for a version.
Update changelog template
edoardopirovano
approved these changes
Jun 23, 2021
Contributor
edoardopirovano
left a comment
edoardopirovano
left a comment
There was a problem hiding this comment.
This LGTM. Was the decision to not include a changelog entry for uploading databases a deliberate one since external users do not have a use for this yet? Seems reasonable but just checking this isn't an accident.
Contributor
|
It was a conscious choice since it's not a user-facing feature yet. See #573 (review) |
Contributor
|
Ah good. Something went wrong and it didn't run any CI on that last commit. Closing and opening has prodded it into action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging d623a7a into v1
Conductor for this PR is @aeisenberg
Contains the following pull requests:
Please review the following: