Conversation
Check if on default branch before uploading database
Provide a better error message
Only attempt to upload on dotcom
rneatherway
approved these changes
Jun 18, 2021
Contributor
rneatherway
left a comment
rneatherway
left a comment
There was a problem hiding this comment.
Agreed we should wait for @aeisenberg to take a look. My feeling is that we don't need a changelog here because this isn't ready for end users yet.
aeisenberg
approved these changes
Jun 18, 2021
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Looks fine to me. I'm leaning against a changelog as well. This is not a user facing feature (yet).
Contributor
|
When query console becomes available to external users, we should add an entry. |
This was referenced Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to upload the CodeQL database to github. These databases will be stored and can then be downloaded by users for running queries against. Currently though this feature is still in development and access will be restricted to github staff.
Most of this work has already been semi-reviewed on the
upload-databasebranch, but it'll likely want a proper review now that we're going into the main branch. Also pay special attention to anything that could make this break for GHES/GHAE users using github connect.I've also added one more commit which adds an input to allow disabling this new behaviour. Although the upload only happens on github.com and only for repositories that are opted in to the new feature, I expect we'll still get requests for a way for users to disable this.
@aeisenberg, does this need a changelog entry? We do add a new input, but also for all regular users behaviour won't be changing either way because their repositories won't be opted in to the new feature. When we roll this out it won't be correlated with any particular codeql-action version.
Merge / deployment checklist