Provide a better error message#564
Merged
robertbrignull merged 1 commit intoupload-databasefrom Jun 17, 2021
Merged
Conversation
aeisenberg
approved these changes
Jun 16, 2021
This was referenced Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Note this is merging into a feature branch, and not into
main)Suggestion from @aeisenberg on #563
This should provide a better error message in the case that the file at
$GITHUB_EVENT_PATHdoesn't exist or isn't valid JSON. I think this level of error handling should be fine and from here we can just let the error propagate upwards. Ideally we wouldn't want the database upload code to cause the action to fail, but that largely just applies to the HTTP requests. In this case an error here is both unlikely and a fundamental problem so I think failing is fine.