[main] Update dependencies from dotnet/runtime dotnet/efcore#46269
[main] Update dependencies from dotnet/runtime dotnet/efcore#46269dotnet-maestro[bot] merged 4 commits intomainfrom
Conversation
…0125.6 Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting From Version 8.0.0-alpha.1.23074.4 -> To Version 8.0.0-alpha.1.23075.6
dotnet-maestro
bot
requested review from
a team,
dougbu and
wtgodbe
as code owners
ghost
added
area-infrastructure
…126.1 dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools From Version 8.0.0-alpha.1.23075.1 -> To Version 8.0.0-alpha.1.23076.1
dotnet-maestro
bot
changed the title
@halter73 looks like we've got a new analyzer failure in Kestrel, can you take a look? |
|
see #34877 (comment), most likely the same suppression is needed here for same reasons. |
…126.2 dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools From Version 8.0.0-alpha.1.23075.1 -> To Version 8.0.0-alpha.1.23076.2
@Tratcher you did some work related to a similar problem in #34877 (comment). What is the guidance here? Should we add |
|
The prior one was for a whole dependency (quic), so we suppressed that at the project level. This is for a specific API so we should suppress it inline. I don't think there's any way to detect availability of the feature. @wfurt? |
|
no, not really. This is result of dotnet/runtime#80717. |
brunolins16
requested review from
BrennanConroy,
JamesNK,
Tratcher,
halter73 and
mgravell
as code owners
|
I pushed the inline suppress. @Tratcher do you want I file an issue to track it? |
|
@brunolins16 Yes, please. The side effect of an error from that method is scary: try
{
#pragma warning disable CA1416 // Validate platform compatibility
await _sslStream.NegotiateClientCertificateAsync(cancellationToken);
#pragma warning restore CA1416 // Validate platform compatibility
}
catch
{
// We can't tell which exceptions are fatal or recoverable. Consider them all recoverable only given a new connection
// and close the connection gracefully to avoid over-caching and affecting future requests on this connection.
// This allows recovery by starting a new connection. The close is graceful to allow the server to
// send an error response like 401. https://github.com/dotnet/aspnetcore/issues/41369
_context.Features.Get<IConnectionLifetimeNotificationFeature>()?.RequestClose();
throw;
}I think we need to investigate what happens if someone calls that method on macOS. We might want to check the OS platform and primitively throw. Or maybe add a catch block for cc @Tratcher |
|
Thanks! We definitely want to improve this, but it doesn't need to block this PR. |
dotnet-maestro
bot
deleted the
darc-main-b24e5745-f386-463f-aa93-8ec4a3a98115
branch
|
Filed #46294 |
6 participants
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
From https://github.com/dotnet/efcore