Skip to content

add unsupported attributes to System.Net.Security#80717

Merged
wfurt merged 4 commits intodotnet:mainfrom
wfurt:unsupported
Jan 18, 2023
Merged

add unsupported attributes to System.Net.Security#80717
wfurt merged 4 commits intodotnet:mainfrom
wfurt:unsupported

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Jan 16, 2023

fixes #57097
The method mentioned are as follow:

  1. QueryContextClientSpecifiedSpn powers NegotiateAuthentication.TargetName on server side

public string? TargetName => IsServer ? _ntAuthentication?.ClientSpecifiedSpn : _ntAuthentication?.Spn;

It seems like the notation is not flexible enough to distinguish client vs server so I'll leave it as is.

  1. CipherSuitesPolicyPal supports public CipherSuitesPolicy. I added unsupported attributes for Windows and Android.
    The Android is interesting as the class has remark about InitializeSslContext and we throw there but the server seems to be ignored. Can you please clarify @simonrozsival ? And any reason why the class does not throw directly just like Windows?

  2. QueryContextAssociatedName was removed in 7.0 by Implement NegotiateAuthentication API #70720

  3. Renegotiate is backend for public NegotiateClientCertificateAsync. Added SupportedOSPlatform attributes.

@wfurt wfurt added this to the 8.0.0 milestone Jan 16, 2023
@wfurt wfurt self-assigned this Jan 16, 2023
@ghost
Copy link

ghost commented Jan 16, 2023

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #57097
The method mentioned are as follow:

  1. QueryContextClientSpecifiedSpn powers NegotiateAuthentication.TargetName on server side

public string? TargetName => IsServer ? _ntAuthentication?.ClientSpecifiedSpn : _ntAuthentication?.Spn;

It seems like the notation is not flexible enough to distinguish client vs server so I'll leave it as is.

  1. CipherSuitesPolicyPal supports public CipherSuitesPolicy. I added unsupported attributes for Windows and Android.
    The Android is interesting as the class has remark about InitializeSslContext and we throw there but the server seems to be ignored. Can you please clarify @simonrozsival ? And any reason why the class does not throw directly just like Windows?

  2. QueryContextAssociatedName was removed in 7.0 by Implement NegotiateAuthentication API #70720

  3. Renegotiate is backend for public NegotiateClientCertificateAsync. Added SupportedOSPlatform attributes.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security

Milestone: 8.0.0

@simonrozsival
Copy link
Member

@wfurt I think you're right that the CipherSuitesPolicyPal should throw PNSE on Android the same way we do it on Windows. We should probably change that.

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotations LGTM

@wfurt wfurt merged commit cdf90c6 into dotnet:main Jan 18, 2023
@wfurt wfurt deleted the unsupported branch January 18, 2023 17:47
mdh1418 pushed a commit to mdh1418/runtime that referenced this pull request Jan 24, 2023
* add unsupported attributes to System.Net.Security

* using

* CA1416
@ghost ghost locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annotate unsupported APIs in System.Net.Security

3 participants