Merged
Conversation
Tratcher
commented
Jul 30, 2021
src/Servers/Kestrel/Core/src/Internal/Infrastructure/TransportManager.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Jul 30, 2021
src/Servers/Kestrel/Transport.Quic/src/WebHostBuilderQuicExtensions.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jul 30, 2021
src/Servers/Kestrel/Kestrel/src/WebHostBuilderKestrelExtensions.cs
Outdated
Show resolved
Hide resolved
wtgodbe
reviewed
Aug 2, 2021
src/Servers/Kestrel/Transport.Quic/src/QuicConnectionFactory.cs
Outdated
Show resolved
Hide resolved
63587d2 to
17e7dee
Compare
wtgodbe
reviewed
Aug 2, 2021
| /// </returns> | ||
| public static IWebHostBuilder UseKestrel(this IWebHostBuilder hostBuilder) | ||
| { | ||
| hostBuilder.UseQuic(); |
Member
There was a problem hiding this comment.
So anyone using Kestrel will be using Quic, even if not using Http3? Does it no-op for Http1/2?
Member
Author
There was a problem hiding this comment.
Right, this adds the services but they're only used if you enable http3.
wtgodbe
approved these changes
Aug 2, 2021
JamesNK
approved these changes
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works to improve the user experience around enabling and configuring Http3 and Quic.
Contributes to #34858, #34517