787 enable uploading multiple files at once #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests also added. note - i will consolidate these endpoints once it is working
New Menu has multiple file uploads, does not work yet
…ogether it does not when they are selected one after the other
max-zilla
reviewed
Oct 19, 2023
max-zilla
reviewed
Oct 19, 2023
Contributor
Author
|
Some recent changes. In the DatasetService.ts, the formData.append() method never appended anything, so I am creating the formdata earlier. There are console logs that show that the formdata does have the right entries. However, when I actually get to making the request, I get a 400 error, and in chrome developer tools, under network, payload, the FormData appears to be blank. This is not the case with the single file. |
error: "WARNING:multipart.multipart:Did not find CR at end of boundary (40)"
* add endpoint and test * codegen and black * add action * add search and get endpoint * add search and get endpoint to action * add to reducer * basic page for metadata definition ready * add delete confirmation * add create metadata modal * ordering in decending order * update message * black * fix the pytest * codegen * fix codegen
* disable ripple effect * fix the stretch --------- Co-authored-by: Chen Wang <[email protected]>
* immediately update before the time interval refresh * add proper reset
* Implement wordcloud visualization * Changing the name
* button to create datasets if none exist * new message * center, no previous and next if we have no datasets
* Updated the labels for Share * Fixed the message
* new page of metadata definition entry * initial page for metadata definition page * basic metadata defintion page
…791) * we now replace the old extractor * created timestamp is from original extractor
* placeholder for where new version select will go * not clickable, new imports * select no longer in version chip new dropdown on filepage problem - current version not selected on file load * does not look good select and file details end up at bottom * clean up the logic * fix bug * make it look nicer * add snackbar * change to half width * change history to details * remove width --------- Co-authored-by: Chen Wang <[email protected]>
* add swagger to traefik * add to deployment * add to ingress rule
* updated * typo * missed more spots
longshuicy
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for now, but the idea is to allow for multiple files to be uploaded at once.
Currently you can select multiple files at the same time, but if you try to select them one after the other it just replaces the file.
Also, I am getting a 422 error on upload.
To see an example of the POST request that works, you can check the new upload_files in the test utils.