Pagination for files & folder page under dataset #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I tested this with a script that uploaded 40 files. Looks good pagination works. Marking approved. |
tcnichol
approved these changes
Oct 19, 2023
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
I wrote a script to upload 40 files, pagination worked back and forth, making approved.
longshuicy
approved these changes
Oct 19, 2023
longshuicy
deleted the
781-add-pagination-on-frontend-for-listing-files-within-dataset
branch
longshuicy
pushed a commit
that referenced
this pull request
Nov 3, 2023
longshuicy
added a commit
that referenced
this pull request
Nov 6, 2023
* endpoint does not work, but new endpoint for multiple files added. tests also added. note - i will consolidate these endpoints once it is working * iterate through files, upload all of them * tests sort of work, need to be cleaned up New Menu has multiple file uploads, does not work yet * multiple property now in, new views, does not upload yet * multiple select selects shows multiple files when they are selected together it does not when they are selected one after the other * logging files when we click finish * codegen, adding multiple files endpoint * getting a 422 for uploading multiple files * does not work * adding print statement back in * adding print statement back in * some changes to how formdata is handled error: "WARNING:multipart.multipart:Did not find CR at end of boundary (40)" * clean up * 734 view and modify list of metadata definitions in UI (#758) * add endpoint and test * codegen and black * add action * add search and get endpoint * add search and get endpoint to action * add to reducer * basic page for metadata definition ready * add delete confirmation * add create metadata modal * ordering in decending order * update message * black * fix the pytest * codegen * fix codegen * stretched icon when extractor description long (#789) * disable ripple effect * fix the stretch --------- Co-authored-by: Chen Wang <[email protected]> * 792 clear previous log before switching extraction logs (#793) * immediately update before the time interval refresh * add proper reset * Pagination for files & folder page under dataset (#797) * Implement wordcloud visualization (#786) * Implement wordcloud visualization * Changing the name * message if no datasets exist, button link to create (#767) * button to create datasets if none exist * new message * center, no previous and next if we have no datasets * Updated the labels for Share (#798) * Updated the labels for Share * Fixed the message * 778 page to display each metadata definition (#801) * new page of metadata definition entry * initial page for metadata definition page * basic metadata defintion page * 788 duplicated extractor registration when extractor version updated (#791) * we now replace the old extractor * created timestamp is from original extractor * 701 improve file version selection (#743) * placeholder for where new version select will go * not clickable, new imports * select no longer in version chip new dropdown on filepage problem - current version not selected on file load * does not look good select and file details end up at bottom * clean up the logic * fix bug * make it look nicer * add snackbar * change to half width * change history to details * remove width --------- Co-authored-by: Chen Wang <[email protected]> * add swagger to traefik (#805) * add swagger to traefik * add to deployment * add to ingress rule * Change hostname to edu (#813) * updated * typo * missed more spots * basic message for no metadata definitions (#766) * endpoint logic is wrong; also fix pytest * write better pytest * rewrite the structure of select file and construct the form in the function * back to bad request again * everything working except redirect * go to the first files route * formatting * codegen * fixing delete of files in tests * fixing package lock --------- Co-authored-by: Chen Wang <[email protected]> Co-authored-by: Dipannita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a dataset with more than 10 files or folders. It should split them in pages containing 10files.