Skip to content

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Oct 10, 2023

Please checkout pyclowder branch in clowder-framework/pyclowder#96

Steps to reproduce:

  1. Upload an appropriate csv file (see attached csv file for example)
  2. Run the extractor.
  3. Look at visualization tab.
    frequent_bigrams.csv
Screenshot 2023-10-10 at 5 55 02 PM

@ddey2 ddey2 requested a review from longshuicy as a code owner October 10, 2023 23:05
@ddey2 ddey2 linked an issue Oct 10, 2023 that may be closed by this pull request
@tcnichol
Copy link
Contributor

Question. I see the preview and it looks right in in the visualization tab. When I try to download the visualization or use a shared link, I get a JSON. That looks like intended behavior given the component, but just wanted to make sure.

If it is, I can mark this one approved.

@ddey2
Copy link
Member Author

ddey2 commented Oct 11, 2023

@tcnichol that's because the vis data is a json (vega spec which is rendered using vega-lite). So, this is correct.

You can save the image as png. that should work.
Screenshot 2023-10-11 at 1 03 38 PM

Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked extractor approved. This visualization looks good and I can save as png and download.

@lmarini lmarini merged commit 205a7ee into main Oct 20, 2023
@lmarini lmarini deleted the 776-implement-extractor-which-works-on-csv-files-for-specific-use-cases branch October 20, 2023 15:36
longshuicy pushed a commit that referenced this pull request Nov 3, 2023
* Implement wordcloud visualization

* Changing the name
longshuicy added a commit that referenced this pull request Nov 6, 2023
* endpoint does not work, but new endpoint for multiple files added.
tests also added.
note - i will consolidate these endpoints once it is working

* iterate through files, upload all of them

* tests sort of work, need to be cleaned up
New Menu has multiple file uploads, does not work yet

* multiple property now in, new views, does not upload yet

* multiple select selects shows multiple files when they are selected together
it does not when they are selected one after the other

* logging files when we click finish

* codegen, adding multiple files endpoint

* getting a 422 for uploading multiple files

* does not work

* adding print statement back in

* adding print statement back in

* some changes to how formdata is handled

error:

"WARNING:multipart.multipart:Did not find CR at end of boundary (40)"

* clean up

* 734 view and modify list of metadata definitions in UI (#758)

* add endpoint and test

* codegen and black

* add action

* add search and get endpoint

* add search and get endpoint to action

* add to reducer

* basic page for metadata definition ready

* add delete confirmation

* add create metadata modal

* ordering in decending order

* update message

* black

* fix the pytest

* codegen

* fix codegen

* stretched icon when extractor description long (#789)

* disable ripple effect

* fix the stretch

---------

Co-authored-by: Chen Wang <[email protected]>

* 792 clear previous log before switching extraction logs (#793)

* immediately update before the time interval refresh

* add proper reset

* Pagination for files & folder page under dataset (#797)

* Implement wordcloud visualization (#786)

* Implement wordcloud visualization

* Changing the name

* message if no datasets exist, button link to create (#767)

* button to create datasets if none exist

* new  message

* center, no previous and next if we have no datasets

* Updated the labels for Share (#798)

* Updated the labels for Share

* Fixed the message

* 778 page to display each metadata definition (#801)

* new page of metadata definition entry

* initial page for metadata definition page

* basic metadata defintion page

* 788 duplicated extractor registration when extractor version updated (#791)

* we now replace the old extractor

* created timestamp is from original extractor

* 701 improve file version selection (#743)

* placeholder for where new version select will go

* not clickable, new imports

* select no longer in version chip
new dropdown on filepage
problem - current version not selected on file load

* does not look good
select and file details end up at bottom

* clean up the logic

* fix bug

* make it look nicer

* add snackbar

* change to half width

* change history to details

* remove width

---------

Co-authored-by: Chen Wang <[email protected]>

* add swagger to traefik (#805)

* add swagger to traefik

* add to deployment

* add to ingress rule

* Change hostname to edu (#813)

* updated

* typo

* missed more spots

* basic message for no metadata definitions (#766)

* endpoint logic is wrong; also fix pytest

* write better pytest

* rewrite the structure of select file and construct the form in the function

* back to bad request again

* everything working except redirect

* go to the first files route

* formatting

* codegen

* fixing delete of files in tests

* fixing package lock

---------

Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement extractor which works on csv files for specific use cases

4 participants