Explore page cleanup #108
Merged
Explore page cleanup #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to clickable card for datasets.
… flushed at the bottom.
… enough for one row.
… default screen size columns size.
# Conflicts: # backend/app/routers/datasets.py # frontend/src/components/Dashbard.tsx
Merged
longshuicy
reviewed
Oct 10, 2022
| Dataset</Button></Box> | ||
| <div className="inner-container"> | ||
| <Grid container spacing={4}> | ||
| <Grid item xs={12} md={8}> |
Member
There was a problem hiding this comment.
I think the xs, md, lg, xl might be needed on the grid. otherwise it looks weird with small number of items
Member
Author
There was a problem hiding this comment.
Thanks for catching this. Should be fixed now
longshuicy
approved these changes
Oct 10, 2022
longshuicy
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Removed placeholder right column on Explore page. Switched to clickable card for datasets. * Show only 5 max lines for description of dataset card and add ellypsis. * Default sort dataset list by creation date descending. * Make sure Dataset CardActionArea fills the card so that CardAction is flushed at the bottom. * Fixed dataset grid so that items are same width even if we don't have enough for one row. * New previous/next buttons on dataset list. * Change default page size for dataset list to 20, a multiple of 4, the default screen size columns size. * Placeholder icons for download card download, favorite, share actions. * Black formatting. * Extra margin around dataset card icons to make it easier to click on icons. * Set outer grid item size for proper layout when there is few datasets.
lmarini
added a commit
that referenced
this pull request
Oct 26, 2022
* replace dataset card * Explore page cleanup (#108) * Removed placeholder right column on Explore page. Switched to clickable card for datasets. * Show only 5 max lines for description of dataset card and add ellypsis. * Default sort dataset list by creation date descending. * Make sure Dataset CardActionArea fills the card so that CardAction is flushed at the bottom. * Fixed dataset grid so that items are same width even if we don't have enough for one row. * New previous/next buttons on dataset list. * Change default page size for dataset list to 20, a multiple of 4, the default screen size columns size. * Placeholder icons for download card download, favorite, share actions. * Black formatting. * Extra margin around dataset card icons to make it easier to click on icons. * Set outer grid item size for proper layout when there is few datasets. * remove wrong primary * add layout * add styling * customize the searchbox * styling the search dataset page * add links to the side bar * add files table * default to its original * add TODOs * Added endpoint to search both file and dataset. * embed datasearch to topbar * add embedded search to the correct place * wrap the search base on parent comp and dynamically switching between index for now * embedded search working now * multi search * combine two searches into one * identify based on index * work on result component * initial styles * add more index * include more fields on file * fix typo * no need to pass dataset name as a query parameter; get that info from backend * black linting * use react router link instead of the refreshing link * remove unused component * bump mui icon version up; use dataset icon Co-authored-by: Luigi Marini <[email protected]> Co-authored-by: Dipannita Dey <[email protected]>
lmarini
added a commit
that referenced
this pull request
Nov 1, 2022
* replace dataset card * Explore page cleanup (#108) * Removed placeholder right column on Explore page. Switched to clickable card for datasets. * Show only 5 max lines for description of dataset card and add ellypsis. * Default sort dataset list by creation date descending. * Make sure Dataset CardActionArea fills the card so that CardAction is flushed at the bottom. * Fixed dataset grid so that items are same width even if we don't have enough for one row. * New previous/next buttons on dataset list. * Change default page size for dataset list to 20, a multiple of 4, the default screen size columns size. * Placeholder icons for download card download, favorite, share actions. * Black formatting. * Extra margin around dataset card icons to make it easier to click on icons. * Set outer grid item size for proper layout when there is few datasets. * remove wrong primary * add layout * add styling * customize the searchbox * styling the search dataset page * add links to the side bar * add files table * default to its original * add TODOs * Added endpoint to search both file and dataset. * embed datasearch to topbar * add embedded search to the correct place * wrap the search base on parent comp and dynamically switching between index for now * embedded search working now * multi search * combine two searches into one * identify based on index * work on result component * initial styles * add more index * include more fields on file * fix typo * no need to pass dataset name as a query parameter; get that info from backend * black linting * use react router link instead of the refreshing link * remove unused component * add error boundary * bump mui icon version up; use dataset icon * add logic to refresh * when expire redirect to login * add refresh mechanism * separate out search error boundary * change route back * put hard coded search endpoint to config * breadcrumb functional now Co-authored-by: Luigi Marini <[email protected]> Co-authored-by: Dipannita Dey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.