132 reactive search routes when token expire logout #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed placeholder right column on Explore page. Switched to clickable card for datasets. * Show only 5 max lines for description of dataset card and add ellypsis. * Default sort dataset list by creation date descending. * Make sure Dataset CardActionArea fills the card so that CardAction is flushed at the bottom. * Fixed dataset grid so that items are same width even if we don't have enough for one row. * New previous/next buttons on dataset list. * Change default page size for dataset list to 20, a multiple of 4, the default screen size columns size. * Placeholder icons for download card download, favorite, share actions. * Black formatting. * Extra margin around dataset card icons to make it easier to click on icons. * Set outer grid item size for proper layout when there is few datasets.
…to dropdown-toggle-between-indices
…to 132-reactive-search-routes-when-token-expire-logout
longshuicy
commented
Oct 24, 2022
| if (error["status"] === 401 || error["status"] === 403) { | ||
| V2.OpenAPI.TOKEN = undefined; | ||
| cookies.remove("Authorization", {path: "/"}); | ||
| return <Navigate to="/auth/login"/>; |
Member
Author
There was a problem hiding this comment.
I cannot properly do the refresh token logic here; for now just redirect to the login page
longshuicy
commented
Oct 24, 2022
| return <Navigate to="/auth/login"/>; | ||
| } else { | ||
| // TODO add prettier message or report function | ||
| return <h1>An error has happened.</h1> |
Member
Author
There was a problem hiding this comment.
This will trigger when elasticsearch is dead (e.g. 500 internal error)
Member
|
There is a build error of the frontend when installing dependencies. |
…esearch # Conflicts: # frontend/package-lock.json
…to 132-reactive-search-routes-when-token-expire-logout
Member
Author
I merge main (where it has the webpack 5 and other dependency change) into the branch that this branch is merged into |
Base automatically changed from
131-custom-widget-and-appearance-for-reactivesearch
to
main
October 26, 2022 15:56
Member
|
Can you resolve conflicts? Thank you! |
Member
Author
done |
lmarini
approved these changes
Nov 1, 2022
lmarini
deleted the
132-reactive-search-routes-when-token-expire-logout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
Set the token expiration in keycloak admin console (http://localhost:8080/keycloak) to 1 minute; and type in the search box see what happened after 1 minute