Drawer menu #129
Drawer menu #129
Conversation
Switched to clickable card for datasets.
… flushed at the bottom.
… enough for one row.
… default screen size columns size.
# Conflicts: # backend/app/routers/datasets.py # frontend/src/components/Dashbard.tsx
Fixed bug in link to registration.
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
At any appropriate time, maybe we can run reformat code to get rid of the unused import?
| import {RootState} from "./types/data"; | ||
| import {resetLogout} from "./actions/common"; | ||
| import Layout from "./components/Layout"; | ||
| import {Paragraph} from "./components/Paragraph"; |
There was a problem hiding this comment.
I don't think Paragraph is being used
There was a problem hiding this comment.
Done. Thanks for the reminder. I try to do it when I remember, but we don't have an automatic way to do this. Also many of my files show in red because of the import React, {useEffect, useState} from "react"; import at the top. React is never used and Typescript doesn't like that.
frontend/src/components/Dashbard.tsx
Outdated
| <div className="inner-container"> | ||
| <Grid container spacing={4}> | ||
| <Grid item xs> | ||
| <Grid item> |
There was a problem hiding this comment.
I still saw the same issue
I think last time you tried xs to fix it; but this time it won't work for me
There was a problem hiding this comment.
I made a new file called Explore.tsx to make it clear that that is the explore page. I fixed it there and remove Dasboard.tsx file to not create confusion.
Depends on #108 . Please merge that first.
New Layout component to wrap pages using the MUI Drawer. All new pages should include this Layout.
Fixed bug in link to registration.
TODO: store open/closed variable for drawer in redux store. Right now the drawer always shows closed after switching pages.