THRIFT-1482: Unix domain socket support under PHP

[balping]

To open a unix socket, the port number supplied to fsockopen (and pfsockopen) has to be -1.

We use substr instead of str_starts_with to keep compatibility with php 7.

Now a UDS can be created like this:

new TSocket('unix:///tmp/ipc.sock', -1)

• Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• Did you squash your changes to a single commit? (not required, but preferred)
• Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
• If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

[sveneld]

@balping apply this patch for test.

Index: lib/php/test/Unit/Lib/Transport/TSocketTest.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/lib/php/test/Unit/Lib/Transport/TSocketTest.php b/lib/php/test/Unit/Lib/Transport/TSocketTest.php
--- a/lib/php/test/Unit/Lib/Transport/TSocketTest.php	(revision 19081602c35311ee13e6ba9ab2fa5001d182048b)
+++ b/lib/php/test/Unit/Lib/Transport/TSocketTest.php	(revision b1d4b05f352ded2ba5b78cb0a4f56dde01a11d41)
@@ -252,6 +252,7 @@
         $port = -1;
         $persist = false;
         $debugHandler = null;
+        $handle = fopen('php://memory', 'r+');
 
         $this->getFunctionMock('Thrift\Transport', 'fsockopen')
              ->expects($this->once())
@@ -261,7 +262,22 @@
                  $this->anything(), #$errno,
                  $this->anything(), #$errstr,
                  $this->anything() #$this->sendTimeoutSec_ + ($this->sendTimeoutUsec_ / 1000000),
-             );
+             )->willReturn($handle);
+
+        $this->getFunctionMock('Thrift\Transport', 'socket_import_stream')
+            ->expects($this->once())
+            ->with($handle)
+            ->willReturn(true);
+
+        $this->getFunctionMock('Thrift\Transport', 'socket_set_option')
+            ->expects($this->once())
+            ->with(
+                $this->anything(), #$socket,
+                SOL_TCP, #$level
+                TCP_NODELAY, #$option
+                1 #$value
+            )
+            ->willReturn(true);
 
         $transport = new TSocket(
             $host,

[sveneld]

@Jens-G what about failing tests?
patch for them should be applied...

[Jens-G]

@Jens-G what about failing tests? patch for them should be applied...

Just noticed and reverted.

[Jens-G]

Any news here?

[sveneld]

@Jens-G I add patch for test and created a new pull request #3130