Skip to content

THRIFT-1482: Unix domain socket support under PHP #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
balping wants to merge 3 commits into from
Closed

THRIFT-1482: Unix domain socket support under PHP #3109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
078e41f
THRIFT-1482: Allow unix domain sockets in TSocket
balping Mar 9, 2025
fffb830
open unix socket test
balping Mar 16, 2025
1908160
THRIFT-1482: strpos implementation
balping Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/php/lib/Transport/TSocket.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ public function open()
throw new TTransportException('Cannot open null host', TTransportException::NOT_OPEN);
}

if ($this->port_ <= 0) {
if ($this->port_ <= 0 && strpos($this->host_, 'unix://') !== 0) {
throw new TTransportException('Cannot open without port', TTransportException::NOT_OPEN);
}

Expand Down
27 changes: 27 additions & 0 deletions lib/php/test/Unit/Lib/Transport/TSocketTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,33 @@ public function testOpenPersist()
$this->assertTrue($transport->isOpen());
}

public function testOpenUnixSocket()
{
$host = 'unix:///tmp/ipc.sock';
$port = -1;
$persist = false;
$debugHandler = null;

$this->getFunctionMock('Thrift\Transport', 'fsockopen')
->expects($this->once())
->with(
$host,
$port,
$this->anything(), #$errno,
$this->anything(), #$errstr,
$this->anything() #$this->sendTimeoutSec_ + ($this->sendTimeoutUsec_ / 1000000),
);

$transport = new TSocket(
$host,
$port,
$persist,
$debugHandler
);

$transport->open();
}

/**
* @dataProvider open_THRIFT_5132_DataProvider
*/
Expand Down
Loading