Skip to content

THRIFT-1482: Unix domain socket support under PHP#3130

Closed
sveneld wants to merge 4 commits intoapache:masterfrom
sveneld:patch-1
Closed

THRIFT-1482: Unix domain socket support under PHP#3130
sveneld wants to merge 4 commits intoapache:masterfrom
sveneld:patch-1

Conversation

@sveneld
Copy link
Copy Markdown
Contributor

@sveneld sveneld commented Apr 26, 2025

Update tests for this pull request #3109

To open a unix socket, the port number supplied to fsockopen (and pfsockopen) has to be -1.

We use substr instead of str_starts_with to keep compatibility with php 7.

Now a UDS can be created like this:

new TSocket('unix:///tmp/ipc.sock', -1)

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

balping and others added 4 commits March 10, 2025 00:13
Client: php

To open a unix socket, the port number supplied to fsockopen (and pfsockopen) has to be -1.

We use substr instead of str_starts_with to keep compatibility with php 7.
@sveneld sveneld marked this pull request as draft April 26, 2025 14:37
@sveneld sveneld changed the title Patch 1 THRIFT-1482: Unix domain socket support under PHP Apr 26, 2025
@sveneld sveneld marked this pull request as ready for review April 26, 2025 14:42
@Jens-G Jens-G closed this in 74ee8b0 Apr 27, 2025
@Jens-G
Copy link
Copy Markdown
Member

Jens-G commented Apr 27, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants