Skip to content

897 add initialization method from flows for lct model#931

Closed
lenaploetzke wants to merge 22 commits intomainfrom
897-add-initialization-method-from-flows-for-lct-model
Closed

897 add initialization method from flows for lct model#931
lenaploetzke wants to merge 22 commits intomainfrom
897-add-initialization-method-from-flows-for-lct-model

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 7, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • added functionality to compute an initial vector for the lct model based on flows

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #897.

lenaploetzke and others added 9 commits February 2, 2024 14:31
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
@lenaploetzke lenaploetzke added class::feature A feature to be implemented for some part of the software prio::moderate The priority of this task is moderate. loc::backend This issue concerns the C++ backend implementation. model::lct Models using the linear chain trick labels Feb 7, 2024
@lenaploetzke lenaploetzke self-assigned this Feb 7, 2024
@lenaploetzke lenaploetzke linked an issue Feb 7, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (ce75c58) to head (4cd50ce).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
+ Coverage   96.36%   96.42%   +0.05%     
==========================================
  Files         123      124       +1     
  Lines        9844    10001     +157     
==========================================
+ Hits         9486     9643     +157     
  Misses        358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke added the status::in progress This issue is in progess. label Feb 7, 2024
@lenaploetzke lenaploetzke added status::in review This issues is in review. and removed status::in progress This issue is in progess. labels Feb 16, 2024
@lenaploetzke lenaploetzke removed the request for review from annawendler March 8, 2024 08:53
@lenaploetzke lenaploetzke removed the request for review from annawendler April 10, 2024 07:58
@lenaploetzke
Copy link
Member Author

Attention: This PR should be also recreated (as PR #929). It also contains the large boost file in the history.

@lenaploetzke lenaploetzke added status::on hold This issue is on hold. and removed class::feature A feature to be implemented for some part of the software prio::moderate The priority of this task is moderate. status::in review This issues is in review. loc::backend This issue concerns the C++ backend implementation. model::lct Models using the linear chain trick labels Apr 10, 2024
@lenaploetzke
Copy link
Member Author

lenaploetzke commented Apr 12, 2024

Moved to PR #1005

@lenaploetzke lenaploetzke deleted the 897-add-initialization-method-from-flows-for-lct-model branch May 13, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status::on hold This issue is on hold.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add initialization method from flows for LCT model

1 participant