897 new add initialization method from flows for lct model 1#1005
Merged
annawendler merged 41 commits intomainfrom Jul 11, 2024
Merged
Conversation
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
…z-archiv' into 899-new-add-gamma-distribution-and-other-parameters-to-state_age_function-1
2 tasks
12 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
+ Coverage 96.24% 96.27% +0.03%
==========================================
Files 127 128 +1
Lines 10886 10992 +106
==========================================
+ Hits 10477 10583 +106
Misses 409 409 ☔ View full report in Codecov by Sentry. |
lenaploetzke
commented
May 14, 2024
annawendler
requested changes
Jun 12, 2024
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
Member
Author
I do not think that initializer_subcompartments is a better name, because e.g. the realistic initialization also initializes subcompartments. The naming should include that we are using flows for initialization. |
Member
Author
|
The LCT model has been updated in the meantime, so small changes had to be made here |
annawendler
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
-/-
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #897.