Skip to content

897 new add initialization method from flows for lct model 1#1005

Merged
annawendler merged 41 commits intomainfrom
897-new-add-initialization-method-from-flows-for-lct-model-1
Jul 11, 2024
Merged

897 new add initialization method from flows for lct model 1#1005
annawendler merged 41 commits intomainfrom
897-new-add-initialization-method-from-flows-for-lct-model-1

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Apr 12, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • added functionality to compute an initial vector for the LCT-SECIR model based on flows

If need be, add additional information and what the reviewer should look out for in particular:

-/-

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #897.

@lenaploetzke lenaploetzke self-assigned this Apr 12, 2024
@lenaploetzke lenaploetzke linked an issue Apr 12, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (d439941) to head (0181407).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   96.24%   96.27%   +0.03%     
==========================================
  Files         127      128       +1     
  Lines       10886    10992     +106     
==========================================
+ Hits        10477    10583     +106     
  Misses        409      409              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke added the status::in review This issues is in review. label Apr 12, 2024
@lenaploetzke lenaploetzke removed the request for review from annawendler April 29, 2024 13:56
@lenaploetzke lenaploetzke added status::in progress This issue is in progess. status::on hold This issue is on hold. and removed status::in review This issues is in review. status::in progress This issue is in progess. labels Apr 29, 2024
@lenaploetzke lenaploetzke removed the status::on hold This issue is on hold. label May 14, 2024
@lenaploetzke lenaploetzke requested a review from annawendler May 14, 2024 06:50
Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice :)

I was thinking that initializer_subcompartments might be a more suitable name than initializer_flows as you are calculating initial values of the subcompartments for given flows.

lenaploetzke and others added 2 commits June 24, 2024 09:23
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
@lenaploetzke
Copy link
Member Author

I was thinking that initializer_subcompartments might be a more suitable name than initializer_flows as you are calculating initial values of the subcompartments for given flows.

I do not think that initializer_subcompartments is a better name, because e.g. the realistic initialization also initializes subcompartments. The naming should include that we are using flows for initialization.

@lenaploetzke lenaploetzke requested a review from annawendler June 24, 2024 13:57
@lenaploetzke
Copy link
Member Author

The LCT model has been updated in the meantime, so small changes had to be made here

@annawendler annawendler merged commit 25e9500 into main Jul 11, 2024
@annawendler annawendler deleted the 897-new-add-initialization-method-from-flows-for-lct-model-1 branch July 11, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add initialization method from flows for LCT model

2 participants